From ac4f951e03eaf635c8dd20a6f42bfc71b0011412 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 10 Dec 2020 23:04:50 +0000 Subject: [PATCH] extmsg: avoid exceptions when /all/$MSGID/ fails If a message can't be found in ->ALL, we shouldn't attempt to enter code paths which iterate normal inboxes or attempt to access non-existent fields (e.g. {name}, {newsgroup}, {inboxdir}) in the ExtSearch object. --- lib/PublicInbox/ExtMsg.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm index 8da96df6..6a173f67 100644 --- a/lib/PublicInbox/ExtMsg.pm +++ b/lib/PublicInbox/ExtMsg.pm @@ -107,7 +107,8 @@ sub ext_msg_ALL ($) { my ($ctx) = @_; my $ALL = $ctx->{www}->{pi_cfg}->ALL or return; my $by_eidx_key = $ctx->{www}->{pi_cfg}->{-by_eidx_key}; - my $cur_key = $ctx->{ibx}->eidx_key; + my $cur_key = eval { $ctx->{ibx}->eidx_key } // + return partial_response($ctx); # $cur->{ibx} == $ALL my %seen = ($cur_key => 1); my ($id, $prev); while (my $x = $ALL->over->next_by_mid($ctx->{mid}, \$id, \$prev)) { -- 2.50.0