package PublicInbox::Config;
use strict;
use warnings;
-use base qw/Exporter/;
-our @EXPORT_OK = qw/try_cat/;
require PublicInbox::Inbox;
+use PublicInbox::Spawn qw(popen_rd);
use File::Path::Expand qw/expand_filename/;
# returns key-value pairs of config directives in a hash
sub new {
my ($class, $file) = @_;
$file = default_file() unless defined($file);
- my $self = bless git_config_dump($file), $class;
- $self->{-by_addr} = {};
- $self->{-by_name} = {};
+ $file = ref $file ? $file : git_config_dump($file);
+ my $self = bless $file, $class;
+
+ # caches
+ $self->{-by_addr} ||= {};
+ $self->{-by_name} ||= {};
$self;
}
my ($self, $name) = @_;
my $rv = $self->{-by_name}->{$name};
return $rv if $rv;
- $self->{-by_name}->{$name} = _fill($self, "publicinbox.$name");
+ $rv = _fill($self, "publicinbox.$name") or return;
+ $self->{-by_name}->{$name} = $rv;
}
sub get {
my ($in, $out);
my @cmd = (qw/git config/, "--file=$file", '-l');
my $cmd = join(' ', @cmd);
- my $pid = open(my $fh, '-|', @cmd);
- defined $pid or die "$cmd failed: $!";
+ my $fh = popen_rd(\@cmd);
my %rv;
+ local $/ = "\n";
foreach my $line (<$fh>) {
chomp $line;
my ($k, $v) = split(/=/, $line, 2);
$rv{$k} = $v;
}
}
- close $fh or die "failed to close ($cmd) pipe: $!";
- $? and warn "$$ $cmd exited with: ($pid) $?";
+ close $fh or die "failed to close ($cmd) pipe: $?";
\%rv;
}
-sub try_cat {
- my ($path) = @_;
- my $rv;
- if (open(my $fh, '<', $path)) {
- local $/;
- $rv = <$fh>;
- }
- $rv;
-}
-
sub _fill {
my ($self, $pfx) = @_;
my $rv = {};
my $v = $self->{"$pfx.$k"};
$rv->{$k} = $v if defined $v;
}
+ return unless $rv->{mainrepo};
my $inbox = $pfx;
$inbox =~ s/\Apublicinbox\.//;
$rv->{name} = $inbox;