use string ref for Email::Simple->new

[public-inbox.git] / lib / PublicInbox / Import.pm

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 7ba166833841ae347106081e4ee76862e7dc21a1..e20c6e031f6fb14a64373637a631f8e1ff9edc93 100644 (file)
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -122,7 +122,7 @@ sub check_remove_v1 {
        $n = read($r, my $lf, 1);
        defined($n) or die "read final byte of cat-blob failed: $!";
        die "bad read on final byte: <$lf>" if $lf ne "\n";
-       my $cur = PublicInbox::MIME->new($buf);
+       my $cur = PublicInbox::MIME->new(\$buf);
        my $cur_s = $cur->header('Subject');
        $cur_s = '' unless defined $cur_s;
        my $cur_m = $mime->header('Subject');
@@ -133,7 +133,6 @@ sub check_remove_v1 {
        (undef, $cur);
 }
 
-# used for v2 (maybe)
 sub checkpoint {
        my ($self) = @_;
        return unless $self->{pid};
@@ -141,6 +140,15 @@ sub checkpoint {
        undef;
 }
 
+sub progress {
+       my ($self, $msg) = @_;
+       return unless $self->{pid};
+       print { $self->{out} } "progress $msg\n" or wfail;
+       $self->{in}->getline eq "progress $msg\n" or die
+               "progress $msg not received\n";
+       undef;
+}
+
 # used for v2
 sub get_mark {
        my ($self, $mark) = @_;
@@ -208,15 +216,50 @@ sub parse_date ($) {
        "$ts $zone";
 }
 
-# returns undef on duplicate
-# returns the :MARK of the most recent commit
-sub add {
-       my ($self, $mime, $check_cb) = @_; # mime = Email::MIME
+sub extract_author_info ($) {
+       my ($mime) = @_;
 
+       my $sender = '';
        my $from = $mime->header('From');
        my ($email) = PublicInbox::Address::emails($from);
        my ($name) = PublicInbox::Address::names($from);
+       if (!defined($name) || !defined($email)) {
+               $sender = $mime->header('Sender');
+               if (!defined($name)) {
+                       ($name) = PublicInbox::Address::names($sender);
+               }
+               if (!defined($email)) {
+                       ($email) = PublicInbox::Address::emails($sender);
+               }
+       }
+       if (defined $email) {
+               # quiet down wide character warnings with utf8::encode
+               utf8::encode($email);
+       } else {
+               $email = '';
+               warn "no email in From: $from or Sender: $sender\n";
+       }
+
+       # git gets confused with:
+       #  "'A U Thor <u@example.com>' via foo" <foo@example.com>
+       # ref:
+       # <CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com>
+       if (defined $name) {
+               $name =~ tr/<>//d;
+               utf8::encode($name);
+       } else {
+               $name = '';
+               warn "no name in From: $from or Sender: $sender\n";
+       }
+       ($name, $email);
+}
+
+# returns undef on duplicate
+# returns the :MARK of the most recent commit
+sub add {
+       my ($self, $mime, $check_cb) = @_; # mime = Email::MIME
 
+       my ($name, $email) = extract_author_info($mime);
        my $date_raw = parse_date($mime);
        my $subject = $mime->header('Subject');
        $subject = '(no subject)' unless defined $subject;
@@ -263,25 +306,6 @@ sub add {
                print $w "reset $ref\n" or wfail;
        }
 
-       # quiet down wide character warnings with utf8::encode
-       if (defined $email) {
-               utf8::encode($email);
-       } else {
-               $email = '';
-               warn "no email in From: $from\n";
-       }
-
-       # git gets confused with:
-       #  "'A U Thor <u@example.com>' via foo" <foo@example.com>
-       # ref:
-       # <CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com>
-       if (defined $name) {
-               $name =~ tr/<>//d;
-               utf8::encode($name);
-       } else {
-               $name = '';
-               warn "no name in From: $from\n";
-       }
        utf8::encode($subject);
        print $w "commit $ref\nmark :$commit\n",
                "author $name <$email> $date_raw\n",