lei: use standard warn() in more places

[public-inbox.git] / lib / PublicInbox / LeiViewText.pm

diff --git a/lib/PublicInbox/LeiViewText.pm b/lib/PublicInbox/LeiViewText.pm
index 3461271191bce865a4e8c48d1d2e6a495fa8f558..2dad3b780fa13af5da27ae23c8d7ef5cb372ec78 100644 (file)
--- a/lib/PublicInbox/LeiViewText.pm
+++ b/lib/PublicInbox/LeiViewText.pm
@@ -77,7 +77,7 @@ sub new {
        my $cfg = PublicInbox::Config::config_fh_parse($r, "\0", "\n");
        waitpid($pid, 0);
        if ($?) {
-               $lei->err("# git-config failed, no color (non-fatal)");
+               warn "# git-config failed, no color (non-fatal)\n";
                return $self;
        }
        $self->{-colored} = \&my_colored;
@@ -96,10 +96,11 @@ sub quote_hdr_buf ($$) {
        for my $f (qw(To Cc)) {
                for my $v ($eml->header_raw($f)) {
                        next if $v !~ /\S/;
-                       $cc .= $v;
+                       $cc .= ", $v";
                        $to //= $v;
                }
        }
+       substr($cc, 0, 2, ''); # s/^, //;
        PublicInbox::View::fold_addresses($to);
        PublicInbox::View::fold_addresses($cc);
        _xs($to);
@@ -244,7 +245,6 @@ sub add_text_buf { # callback for Eml->each_part
        hdr_buf($self, $part) if $part->{is_submsg};
        $s =~ s/\r\n/\n/sg;
        _xs($s);
-       $s .= "\n" unless substr($s, -1, 1) eq "\n";
        my $diff = ($s =~ /^--- [^\n]+\n\+{3} [^\n]+\n@@ /ms);
        my @sections = PublicInbox::MsgIter::split_quotes($s);
        undef $s; # free memory