www: use PerlIO::scalar (zfh) for buffering

[public-inbox.git] / lib / PublicInbox / Mbox.pm

diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index dede4825ff1381f4076fee8cc1f01d4a5035f09d..2ef8ff2ba48da7e52d2aebbde3d035c001c23503 100644 (file)
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
 # Streaming interface for mboxrd HTTP responses
@@ -18,14 +18,13 @@ sub getline {
        my ($ctx) = @_; # ctx
        my $smsg = $ctx->{smsg} or return;
        my $ibx = $ctx->{ibx};
-       my $eml = $ibx->smsg_eml($smsg) or return;
+       my $eml = delete($ctx->{eml}) // $ibx->smsg_eml($smsg) // return;
        my $n = $ctx->{smsg} = $ibx->over->next_by_mid(@{$ctx->{next_arg}});
        $ctx->zmore(msg_hdr($ctx, $eml));
        if ($n) {
                $ctx->translate(msg_body($eml));
        } else { # last message
-               $ctx->zmore(msg_body($eml));
-               $ctx->zflush;
+               $ctx->zflush(msg_body($eml));
        }
 }
 
@@ -45,14 +44,15 @@ sub async_eml { # for async_blob_cb
        my $smsg = delete $ctx->{smsg};
        # next message
        $ctx->{smsg} = $ctx->{ibx}->over->next_by_mid(@{$ctx->{next_arg}});
-
+       local $ctx->{eml} = $eml; # for mbox_hdr
        $ctx->zmore(msg_hdr($ctx, $eml));
-       $ctx->{http_out}->write($ctx->translate(msg_body($eml)));
+       $ctx->write(msg_body($eml));
 }
 
-sub res_hdr ($$) {
-       my ($ctx, $subject) = @_;
-       my $fn = $subject // '';
+sub mbox_hdr ($) {
+       my ($ctx) = @_;
+       my $eml = $ctx->{eml} //= $ctx->{ibx}->smsg_eml($ctx->{smsg});
+       my $fn = $eml->header_str('Subject') // '';
        $fn =~ s/^re:\s+//i;
        $fn = to_filename($fn) // 'no-subject';
        my @hdr = ('Content-Type');
@@ -64,30 +64,30 @@ sub res_hdr ($$) {
                push @hdr, 'text/plain';
                $fn .= '.txt';
        }
+       my $cs = $ctx->{eml}->ct->{attributes}->{charset} // 'UTF-8';
+       $cs = 'UTF-8' if $cs =~ /[^a-zA-Z0-9\-\_]/; # avoid header injection
+       $hdr[-1] .= "; charset=$cs";
        push @hdr, 'Content-Disposition', "inline; filename=$fn";
-       \@hdr;
+       [ 200, \@hdr ];
 }
 
 # for rare cases where v1 inboxes aren't indexed w/ ->over at all
 sub no_over_raw ($) {
        my ($ctx) = @_;
        my $mref = $ctx->{ibx}->msg_by_mid($ctx->{mid}) or return;
-       my $eml = PublicInbox::Eml->new($mref);
-       [ 200, res_hdr($ctx, $eml->header_str('Subject')),
-               [ msg_hdr($ctx, $eml) . msg_body($eml) ] ]
+       my $eml = $ctx->{eml} = PublicInbox::Eml->new($mref);
+       [ @{mbox_hdr($ctx)}, [ msg_hdr($ctx, $eml) . msg_body($eml) ] ]
 }
 
 # /$INBOX/$MESSAGE_ID/raw
 sub emit_raw {
        my ($ctx) = @_;
-       $ctx->{base_url} = $ctx->{ibx}->base_url($ctx->{env});
        my $over = $ctx->{ibx}->over or return no_over_raw($ctx);
        my ($id, $prev);
        my $mip = $ctx->{next_arg} = [ $ctx->{mid}, \$id, \$prev ];
        my $smsg = $ctx->{smsg} = $over->next_by_mid(@$mip) or return;
-       my $res_hdr = res_hdr($ctx, $smsg->{subject});
        bless $ctx, __PACKAGE__;
-       $ctx->psgi_response(200, $res_hdr);
+       $ctx->psgi_response(\&mbox_hdr);
 }
 
 sub msg_hdr ($$) {