wwwstream: prioritize search in top title bar

[public-inbox.git] / lib / PublicInbox / Msgmap.pm

diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm
index 8a34e7e0c713a4036cd156de22795a525320e5d7..2583ff47422c4e1d7c3d9e36344c453ea891b9b5 100644 (file)
--- a/lib/PublicInbox/Msgmap.pm
+++ b/lib/PublicInbox/Msgmap.pm
@@ -1,6 +1,12 @@
 # Copyright (C) 2015 all contributors <meta@public-inbox.org>
 # License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt)
-# bidirectional Message-ID <-> Article Number mapping
+
+# bidirectional Message-ID <-> Article Number mapping for the NNTP
+# and web interfaces.  This is required for implementing stable article
+# numbers for NNTP and allows prefix lookups for partial Message-IDs
+# in case URLs get truncated from copy-n-paste errors by users.
+#
+# This is maintained by ::SearchIdx
 package PublicInbox::Msgmap;
 use strict;
 use warnings;
@@ -19,6 +25,7 @@ sub new {
                AutoCommit => 1,
                RaiseError => 1,
                PrintError => 0,
+               ReadOnly => !$writable,
                sqlite_use_immediate_transaction => 1,
        });
        $dbh->do('PRAGMA case_sensitive_like = ON');
@@ -26,7 +33,9 @@ sub new {
 
        if ($writable) {
                create_tables($dbh);
+               $dbh->begin_work;
                $self->created_at(time) unless $self->created_at;
+               $dbh->commit;
        }
        $self;
 }
@@ -44,22 +53,14 @@ sub meta_accessor {
        defined $value or
                return $dbh->selectrow_array(meta_select, undef, $key);
 
-       $dbh->begin_work;
-       eval {
-               $prev = $dbh->selectrow_array(meta_select, undef, $key);
-
-               if (defined $prev) {
-                       $dbh->do(meta_update, undef, $value, $key);
-               } else {
-                       $dbh->do(meta_insert, undef, $key, $value);
-               }
-               $dbh->commit;
-       };
-       my $err = $@;
-       return $prev unless $err;
+       $prev = $dbh->selectrow_array(meta_select, undef, $key);
 
-       $dbh->rollback;
-       die $err;
+       if (defined $prev) {
+               $dbh->do(meta_update, undef, $value, $key);
+       } else {
+               $dbh->do(meta_insert, undef, $key, $value);
+       }
+       $prev;
 }
 
 sub last_commit {