-# Copyright (C) 2016-2018 all contributors <meta@public-inbox.org>
+# Copyright (C) 2016-2020 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# represents an NNTPD (currently a singleton),
use strict;
use warnings;
use Sys::Hostname;
-require PublicInbox::Config;
+use PublicInbox::Config;
sub new {
my ($class) = @_;
out => \*STDOUT,
grouplist => [],
servername => $name,
+ greet => \"201 $name ready - post via email\r\n",
# accept_tls => { SSL_server => 1, ..., SSL_reuse_ctx => ... }
}, $class;
}
-sub refresh_groups () {
- my ($self) = @_;
- my $pi_config = PublicInbox::Config->new;
+sub refresh_groups {
+ my ($self, $pi_config) = @_;
+ $pi_config //= PublicInbox::Config->new;
my $new = {};
my @list;
$pi_config->each_inbox(sub {
if (ref $ngname) {
warn 'multiple newsgroups not supported: '.
join(', ', @$ngname). "\n";
+ # Newsgroup name needs to be compatible with RFC 3977
+ # wildmat-exact and RFC 3501 (IMAP) ATOM-CHAR.
+ # Leave out a few chars likely to cause problems or conflicts:
+ # '|', '<', '>', ';', '#', '$', '&',
+ } elsif ($ngname =~ m![^A-Za-z0-9/_\.\-\~\@\+\=:]!) {
+ warn "newsgroup name invalid: `$ngname'\n";
} elsif ($ng->nntp_usable) {
# Only valid if msgmap and search works
$new->{$ngname} = $ng;
push @list, $ng;
+
+ # preload to avoid fragmentation:
+ $ng->description;
+ $ng->base_url;
}
});
@list = sort { $a->{newsgroup} cmp $b->{newsgroup} } @list;