doc: TODO and release notes updates ahead of 1.6

[public-inbox.git] / lib / PublicInbox / OverIdx.pm

diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 67f8cf656958d78440ba13e7115915065021cacf..db4b7738dfd602b339072bd8d7b6db31d7e71a54 100644 (file)
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -184,23 +184,20 @@ sub resolve_mid_to_tid {
        if (my $del = delete $self->{-ghosts_to_delete}) {
                delete_by_num($self, $_) for @$del;
        }
-       $tid // create_ghost($self, $mid);
-}
-
-sub create_ghost {
-       my ($self, $mid) = @_;
-       my $id = mid2id($self, $mid);
-       my $num = next_ghost_num($self);
-       $num < 0 or die "ghost num is non-negative: $num\n";
-       my $tid = next_tid($self);
-       my $dbh = $self->{dbh};
-       $dbh->prepare_cached(<<'')->execute($num, $tid);
+       $tid // do { # create a new ghost
+               my $id = mid2id($self, $mid);
+               my $num = next_ghost_num($self);
+               $num < 0 or die "ghost num is non-negative: $num\n";
+               $tid = next_tid($self);
+               my $dbh = $self->{dbh};
+               $dbh->prepare_cached(<<'')->execute($num, $tid);
 INSERT INTO over (num, tid) VALUES (?,?)
 
-       $dbh->prepare_cached(<<'')->execute($id, $num);
+               $dbh->prepare_cached(<<'')->execute($id, $num);
 INSERT INTO id2num (id, num) VALUES (?,?)
 
-       $tid;
+               $tid;
+       };
 }
 
 sub merge_threads {
@@ -382,12 +379,12 @@ sub create_tables {
 
        $dbh->do(<<'');
 CREATE TABLE IF NOT EXISTS over (
-       num INTEGER NOT NULL,
-       tid INTEGER NOT NULL,
-       sid INTEGER,
-       ts INTEGER,
-       ds INTEGER,
-       ddd VARBINARY, /* doc-data-deflated */
+       num INTEGER NOT NULL, /* NNTP article number == IMAP UID */
+       tid INTEGER NOT NULL, /* THREADID (IMAP REFERENCES threading, JMAP) */
+       sid INTEGER, /* Subject ID (IMAP ORDEREDSUBJECT "threading") */
+       ts INTEGER, /* IMAP INTERNALDATE (Received: header, git commit time) */
+       ds INTEGER, /* RFC-2822 sent Date: header, git author time */
+       ddd VARBINARY, /* doc-data-deflated (->to_doc_data, ->load_from_data) */
        UNIQUE (num)
 )
 
@@ -409,13 +406,13 @@ CREATE TABLE IF NOT EXISTS counter (
        $dbh->do(<<'');
 CREATE TABLE IF NOT EXISTS subject (
        sid INTEGER PRIMARY KEY AUTOINCREMENT,
-       path VARCHAR(40) NOT NULL,
+       path VARCHAR(40) NOT NULL, /* SHA-1 of normalized subject */
        UNIQUE (path)
 )
 
        $dbh->do(<<'');
 CREATE TABLE IF NOT EXISTS id2num (
-       id INTEGER NOT NULL,
+       id INTEGER NOT NULL, /* <=> msgid.id */
        num INTEGER NOT NULL,
        UNIQUE (id, num)
 )
@@ -426,7 +423,7 @@ CREATE TABLE IF NOT EXISTS id2num (
 
        $dbh->do(<<'');
 CREATE TABLE IF NOT EXISTS msgid (
-       id INTEGER PRIMARY KEY AUTOINCREMENT,
+       id INTEGER PRIMARY KEY AUTOINCREMENT, /* <=> id2num.id */
        mid VARCHAR(244) NOT NULL,
        UNIQUE (mid)
 )