smsg: add ->oidbin method

[public-inbox.git] / lib / PublicInbox / OverIdx.pm

diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 46f7a066275a74bd31f9c5670dc15c3bbfbee236..e7c96e143749486d33e9b091752e712002d04e97 100644 (file)
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -434,6 +434,7 @@ sub commit_lazy {
        my ($self) = @_;
        delete $self->{txn} or return;
        $self->{dbh}->commit;
+       eval { $self->{dbh}->do('PRAGMA optimize') };
 }
 
 sub begin_lazy {
@@ -606,50 +607,6 @@ INSERT OR IGNORE INTO xref3 (docid, ibx_id, xnum, oidbin) VALUES (?, ?, ?, ?)
        $sth->execute;
 }
 
-# returns remaining reference count to $docid
-sub remove_xref3 {
-       my ($self, $docid, $oidhex, $eidx_key, $rm_eidx_info) = @_;
-       begin_lazy($self);
-       my $oidbin = pack('H*', $oidhex);
-       my ($sth, $ibx_id);
-       if (defined $eidx_key) {
-               $ibx_id = ibx_id($self, $eidx_key);
-               $sth = $self->{dbh}->prepare_cached(<<'');
-DELETE FROM xref3 WHERE docid = ? AND ibx_id = ? AND oidbin = ?
-
-               $sth->bind_param(1, $docid);
-               $sth->bind_param(2, $ibx_id);
-               $sth->bind_param(3, $oidbin, SQL_BLOB);
-       } else {
-               $sth = $self->{dbh}->prepare_cached(<<'');
-DELETE FROM xref3 WHERE docid = ? AND oidbin = ?
-
-               $sth->bind_param(1, $docid);
-               $sth->bind_param(2, $oidbin, SQL_BLOB);
-       }
-       $sth->execute;
-       $sth = $self->{dbh}->prepare_cached(<<'', undef, 1);
-SELECT COUNT(*) FROM xref3 WHERE docid = ?
-
-       $sth->execute($docid);
-       my $nr = $sth->fetchrow_array;
-       if ($nr == 0) {
-               delete_by_num($self, $docid);
-       } elsif (defined($ibx_id) && $rm_eidx_info) {
-               # if deduplication rules in ContentHash change, it's
-               # possible a docid can have multiple rows with the
-               # same ibx_id.  This governs whether or not we call
-               # ->remove_eidx_info in ExtSearchIdx.
-               $sth = $self->{dbh}->prepare_cached(<<'', undef, 1);
-SELECT COUNT(*) FROM xref3 WHERE docid = ? AND ibx_id = ?
-
-               $sth->execute($docid, $ibx_id);
-               my $count = $sth->fetchrow_array;
-               $$rm_eidx_info = ($count == 0);
-       }
-       $nr;
-}
-
 # for when an xref3 goes missing, this does NOT update {ts}
 sub update_blob {
        my ($self, $smsg, $oidhex) = @_;
@@ -663,8 +620,7 @@ UPDATE over SET ddd = ? WHERE num = ?
 }
 
 sub merge_xref3 { # used for "-extindex --dedupe"
-       my ($self, $keep_docid, $drop_docid, $oidhex) = @_;
-       my $oidbin = pack('H*', $oidhex);
+       my ($self, $keep_docid, $drop_docid, $oidbin) = @_;
        my $sth = $self->{dbh}->prepare_cached(<<'');
 UPDATE OR IGNORE xref3 SET docid = ? WHERE docid = ? AND oidbin = ?