qspawn: log errors for generic PSGI server users

[public-inbox.git] / lib / PublicInbox / Qspawn.pm

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 54976b008d839b302a0d4c262157691f32818a07..844d50f7cdeedb6775df8183df8a2d3f9bb83c18 100644 (file)
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -116,10 +116,9 @@ sub waitpid_err ($$) {
 sub do_waitpid ($;$) {
        my ($self, $env) = @_;
        my $pid = $self->{pid};
-       eval { # PublicInbox::DS may not be loaded
-               PublicInbox::DS::dwaitpid($pid, \&waitpid_err, $self);
-               $self->{env} = $env;
-       };
+       $self->{env} = $env;
+       # PublicInbox::DS may not be loaded
+       eval { PublicInbox::DS::dwaitpid($pid, \&waitpid_err, $self) };
        # done if we're running in PublicInbox::DS::EventLoop
        if ($@) {
                # non public-inbox-{httpd,nntpd} callers may block:
@@ -141,7 +140,6 @@ sub finish ($;$) {
                        _do_spawn(@$next);
                }
        }
-       $self->{err}; # may be meaningless if non-blocking
 }
 
 sub start {