thread: avoid Perl5 internal scratchpad target cache

[public-inbox.git] / lib / PublicInbox / SearchView.pm

diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 91196ccafc9f21a710b6fe71bafadc18f190315c..b1cdb480d75d2ef97a76d024ab95ad8736f85f52 100644 (file)
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -102,11 +102,8 @@ sub mset_summary {
 
        foreach my $m ($mset->items) {
                my $num = shift @nums;
-               my $smsg = delete($num2msg{$num}) or do {
-                       eval {
-                               $m = "$m $num expired\n";
-                               $ctx->{env}->{'psgi.errors'}->print($m);
-                       };
+               my $smsg = delete($num2msg{$num}) // do {
+                       warn "$m $num expired\n";
                        next;
                };
                my $mid = $smsg->{mid};
@@ -122,7 +119,7 @@ sub mset_summary {
                $min = $pct;
 
                my $s = ascii_html($smsg->{subject});
-               my $f = ascii_html($smsg->{from_name});
+               my $f = ascii_html(delete $smsg->{from_name});
                if ($obfs_ibx) {
                        obfuscate_addrs($obfs_ibx, $s);
                        obfuscate_addrs($obfs_ibx, $f);
@@ -277,10 +274,10 @@ sub search_nav_bot { # also used by WwwListing for searching extindex miscidx
 }
 
 sub sort_relevance {
-       [ sort {
+       @{$_[0]} = sort {
                (eval { $b->topmost->{pct} } // 0) <=>
                (eval { $a->topmost->{pct} } // 0)
-       } @{$_[0]} ]
+       } @{$_[0]};
 }
 
 sub mset_thread {