thread: pass array refs instead of entire arrays

[public-inbox.git] / lib / PublicInbox / View.pm

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 93592097353eef0aa045b049673244adb527bdcc..e90efda16783ec2241050eededef689ae55af2a5 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -723,8 +723,6 @@ sub anchor_for {
 
 sub ghost_parent {
        my ($upfx, $mid) = @_;
-       # 'subject dummy' is used internally by Mail::Thread
-       return '[no common parent]' if ($mid eq 'subject dummy');
 
        $mid = PublicInbox::Hval->new_msgid($mid);
        my $href = $mid->{href};
@@ -751,8 +749,8 @@ sub msg_timestamp {
 
 sub thread_results {
        my ($msgs) = @_;
-       require PublicInbox::Thread;
-       my $th = PublicInbox::Thread->new(@$msgs);
+       require PublicInbox::SearchThread;
+       my $th = PublicInbox::SearchThread->new($msgs);
        $th->thread;
        $th->order(*sort_ts);
        $th
@@ -838,12 +836,6 @@ sub skel_dump {
                my $dst = $ctx->{dst};
                my $mapping = $ctx->{mapping};
                my $map = $mapping->{$mid} if $mapping;
-               if ($mid eq 'subject dummy') {
-                       my $ncp = "\t[no common parent]\n";
-                       $map->[1] = $ncp if $map;
-                       $$dst .= $ncp;
-                       return;
-               }
                my $d = $ctx->{pct} ? '    [irrelevant] ' # search result
                                    : '     [not found] ';
                $d .= indent_for($level) . th_pfx($level);
@@ -864,10 +856,10 @@ sub skel_dump {
 }
 
 sub sort_ts {
-       sort {
+       [ sort {
                (eval { $a->topmost->message->header('X-PI-TS') } || 0) <=>
                (eval { $b->topmost->message->header('X-PI-TS') } || 0)
-       } @_;
+       } @{$_[0]} ];
 }
 
 sub _tryload_ghost ($$) {