get rid of unnecessary bytes::length usage

[public-inbox.git] / lib / PublicInbox / ViewDiff.pm

diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm
index d2c5fabef64b9c12c9a72ff9def1a67a229c7c28..f492b6971981706753480f8bc36554f7cd43b120 100644 (file)
--- a/lib/PublicInbox/ViewDiff.pm
+++ b/lib/PublicInbox/ViewDiff.pm
@@ -15,8 +15,7 @@ use URI::Escape qw(uri_escape_utf8);
 use PublicInbox::Hval qw(ascii_html to_attr);
 use PublicInbox::Git qw(git_unquote);
 
-sub UNSAFE () { "^A-Za-z0-9\-\._~/" }
-
+my $UNSAFE = "^A-Za-z0-9\-\._~/"; # '/' + $URI::Escape::Unsafe{RFC3986}
 my $OID_NULL = '0{7,}';
 my $OID_BLOB = '[a-f0-9]{7,}';
 my $LF = qr!\n!;
@@ -78,7 +77,7 @@ sub anchor0 ($$$$) {
        # which works well in practice. If projects put "=>", or trailing
        # spaces in filenames, oh well :P
        $fn =~ s/$DIFFSTAT_COMMENT//;
-       $fn =~ s/{(?:.+) => (.+)}/$1/ or $fn =~ s/.* => (.+)/$1/;
+       $fn =~ s/\{(?:.+) => (.+)\}/$1/ or $fn =~ s/.* => (.+)/$1/;
        $fn = git_unquote($fn);
 
        # long filenames will require us to check in anchor1()
@@ -124,14 +123,14 @@ sub diff_header ($$$) {
        $pa = (split(m'/', git_unquote($pa), 2))[1] if $pa ne '/dev/null';
        $pb = (split(m'/', git_unquote($pb), 2))[1] if $pb ne '/dev/null';
        if ($pa eq $pb && $pb ne '/dev/null') {
-               $dctx->{Q} = "?b=".uri_escape_utf8($pb, UNSAFE);
+               $dctx->{Q} = "?b=".uri_escape_utf8($pb, $UNSAFE);
        } else {
                my @q;
                if ($pb ne '/dev/null') {
-                       push @q, 'b='.uri_escape_utf8($pb, UNSAFE);
+                       push @q, 'b='.uri_escape_utf8($pb, $UNSAFE);
                }
                if ($pa ne '/dev/null') {
-                       push @q, 'a='.uri_escape_utf8($pa, UNSAFE);
+                       push @q, 'a='.uri_escape_utf8($pa, $UNSAFE);
                }
                $dctx->{Q} = '?'.join('&', @q);
        }