www: use PerlIO::scalar (zfh) for buffering

[public-inbox.git] / lib / PublicInbox / WwwAtomStream.pm

diff --git a/lib/PublicInbox/WwwAtomStream.pm b/lib/PublicInbox/WwwAtomStream.pm
index 912f860ececa8e16e13a7782ae96b625d4d78bb7..33da32443c0f941cb01ce6de07a625b03d176097 100644 (file)
--- a/lib/PublicInbox/WwwAtomStream.pm
+++ b/lib/PublicInbox/WwwAtomStream.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2016-2020 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 #
 # Atom body stream for HTTP responses
@@ -28,7 +28,7 @@ sub async_next ($) {
                if (my $smsg = $ctx->{smsg} = $ctx->{cb}->($ctx)) {
                        $ctx->smsg_blob($smsg);
                } else {
-                       $ctx->{http_out}->write($ctx->translate('</feed>'));
+                       $ctx->write('</feed>');
                        $ctx->close;
                }
        };
@@ -38,14 +38,15 @@ sub async_next ($) {
 sub async_eml { # for async_blob_cb
        my ($ctx, $eml) = @_;
        my $smsg = delete $ctx->{smsg};
-       $ctx->{http_out}->write($ctx->translate(feed_entry($ctx, $smsg, $eml)))
+       $smsg->{mid} // $smsg->populate($eml);
+       $ctx->write(feed_entry($ctx, $smsg, $eml));
 }
 
 sub response {
-       my ($class, $ctx, $code, $cb) = @_;
+       my ($class, $ctx, $cb) = @_;
        my $res_hdr = [ 'Content-Type' => 'application/atom+xml' ];
        $class->new($ctx, $cb);
-       $ctx->psgi_response($code, $res_hdr);
+       $ctx->psgi_response(200, $res_hdr);
 }
 
 # called once for each message by PSGI server
@@ -100,7 +101,11 @@ sub atom_header {
        } else {
                $title = title_tag($ibx->description);
                $self_url .= 'new.atom';
-               $page_id = "mailto:$ibx->{-primary_address}";
+               if (defined(my $addr = $ibx->{-primary_address})) {
+                       $page_id = "mailto:$addr";
+               } else {
+                       $page_id = to_uuid($self_url);
+               }
        }
        qq(<?xml version="1.0" encoding="us-ascii"?>\n) .
        qq(<feed\nxmlns="http://www.w3.org/2005/Atom"\n) .
@@ -141,23 +146,24 @@ sub feed_entry {
        my $name = ascii_html(join(', ', PublicInbox::Address::names($from)));
        $email = ascii_html($email // $ctx->{ibx}->{-primary_address});
 
-       my $s = delete($ctx->{emit_header}) ? atom_header($ctx, $title) : '';
-       $s .= "<entry><author><name>$name</name><email>$email</email>" .
+       print { $ctx->zfh }
+               (delete($ctx->{emit_header}) ? atom_header($ctx, $title) : ''),
+               "<entry><author><name>$name</name><email>$email</email>" .
                "</author>$title$updated" .
-               qq(<link\nhref="$href"/>).
+               qq(<link\nhref="$href"/>) .
                "<id>$uuid</id>$irt" .
                qq{<content\ntype="xhtml">} .
                qq{<div\nxmlns="http://www.w3.org/1999/xhtml">} .
                qq(<pre\nstyle="white-space:pre-wrap">);
-       $ctx->{obuf} = \$s;
        $ctx->{mhref} = $href;
-       PublicInbox::View::multipart_text_as_html($eml, $ctx);
-       delete $ctx->{obuf};
-       $s .= '</pre></div></content></entry>';
+       $ctx->{changed_href} = "${href}#related";
+       $eml->each_part(\&PublicInbox::View::add_text_body, $ctx, 1);
+       '</pre></div></content></entry>';
 }
 
 sub feed_updated {
-       '<updated>' . strftime('%Y-%m-%dT%H:%M:%SZ', gmtime(@_)) . '</updated>';
+       my ($t) = @_;
+       '<updated>' . strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($t)) . '</updated>';
 }
 
 1;