wwwstream: use parent.pm and no warnings

[public-inbox.git] / lib / PublicInbox / WwwListing.pm
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm

index 780c97e913b22a9d2427aa4d7cd5a3c80f4a65ea..5f85e3464bc84d9b76986ddedd313cb30347f168 100644 (file)
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -10,7 +10,6 @@ use PublicInbox::Hval qw(ascii_html prurl);
  use PublicInbox::Linkify;
  use PublicInbox::View;
  use PublicInbox::Inbox;
-use PublicInbox::NoopFilter;
  use PublicInbox::GzipFilter qw(gzf_maybe);
  use bytes (); # bytes::length
  use HTTP::Date qw(time2str);
@@ -108,8 +107,8 @@ sub html ($$) {
         my ($env, $list) = @_;
         my $h = [ 'Content-Type', 'text/html; charset=UTF-8',
                         'Content-Length', undef ];
-       my $gzf = gzf_maybe($h, $env) || PublicInbox::NoopFilter::new();
-       my $out = $gzf->zmore('<html><head><title>' .
+       my $gzf = gzf_maybe($h, $env);
+       $gzf->zmore('<html><head><title>' .
                                 'public-inbox listing</title>' .
                                 '</head><body><pre>');
         my $code = 404;
@@ -122,11 +121,11 @@ sub html ($$) {
  
                 my $tmp = join("\n", map { ibx_entry(@$_, $env) } @$list);
                 my $l = PublicInbox::Linkify->new;
-               $out .= $gzf->zmore($l->to_html($tmp));
+               $gzf->zmore($l->to_html($tmp));
         } else {
-               $out .= $gzf->zmore('no inboxes, yet');
+               $gzf->zmore('no inboxes, yet');
         }
-       $out .= $gzf->zflush('</pre><hr><pre>'.
+       my $out = $gzf->zflush('</pre><hr><pre>'.
                                 PublicInbox::WwwStream::code_footer($env) .
                                 '</pre></body></html>');
         $h->[3] = bytes::length($out);