treewide: shorten temporary filename

[public-inbox.git] / script / lei

diff --git a/script/lei b/script/lei
index f92dd302525fca9eb41b93ee580264c588e659c6..cb605e2eac1dc7bf9259b84e95dc506e5e8df4d9 100755 (executable)
--- a/script/lei
+++ b/script/lei
@@ -4,10 +4,9 @@
 use strict;
 use v5.10.1;
 use Socket qw(AF_UNIX SOCK_SEQPACKET MSG_EOR pack_sockaddr_un);
-use Errno qw(EINTR ECONNRESET);
 use PublicInbox::CmdIPC4;
 my $narg = 5;
-my ($sock, $pwd);
+my $sock;
 my $recv_cmd = PublicInbox::CmdIPC4->can('recv_cmd4');
 my $send_cmd = PublicInbox::CmdIPC4->can('send_cmd4') // do {
        require PublicInbox::Spawn; # takes ~50ms even if built *sigh*
@@ -15,13 +14,15 @@ my $send_cmd = PublicInbox::CmdIPC4->can('send_cmd4') // do {
        PublicInbox::Spawn->can('send_cmd4');
 };
 
-sub sigchld {
-       my ($sig) = @_;
-       my $flags = $sig ? POSIX::WNOHANG() : 0;
-       while (waitpid(-1, $flags) > 0) {}
-}
+my %pids;
+my $sigchld = sub {
+       my $flags = scalar(@_) ? POSIX::WNOHANG() : 0;
+       for my $pid (keys %pids) {
+               delete($pids{$pid}) if waitpid($pid, $flags) == $pid;
+       }
+};
 
-sub exec_cmd {
+my $exec_cmd = sub {
        my ($fds, $argc, @argv) = @_;
        my @old = (*STDIN{IO}, *STDOUT{IO}, *STDERR{IO});
        my @rdr;
@@ -30,7 +31,7 @@ sub exec_cmd {
                push @rdr, shift(@old), $tmpfh;
        }
        require POSIX; # WNOHANG
-       $SIG{CHLD} = \&sigchld;
+       $SIG{CHLD} = $sigchld;
        my $pid = fork // die "fork: $!";
        if ($pid == 0) {
                my %env = map { split(/=/, $_, 2) } splice(@argv, $argc);
@@ -39,9 +40,11 @@ sub exec_cmd {
                }
                %ENV = (%ENV, %env);
                exec(@argv);
-               die "exec: @argv: $!";
+               warn "exec: @argv: $!\n";
+               POSIX::_exit(1);
        }
-}
+       $pids{$pid} = 1;
+};
 
 if ($send_cmd && eval {
        my $path = do {
@@ -73,39 +76,45 @@ connect($path): $! (after attempted daemon start)
 Falling back to (slow) one-shot mode
 
        }
-       1;
-}) { # (Socket::MsgHdr|Inline::C), $sock, $pwd are all available:
+       # (Socket::MsgHdr|Inline::C), $sock are all available:
        open my $dh, '<', '.' or die "open(.) $!";
        my $buf = join("\0", scalar(@ARGV), @ARGV);
        while (my ($k, $v) = each %ENV) { $buf .= "\0$k=$v" }
        $buf .= "\0\0";
-       $send_cmd->($sock, [ 0, 1, 2, fileno($dh) ], $buf, MSG_EOR) or
-               die "sendmsg: $!";
+       my $n = $send_cmd->($sock, [0, 1, 2, fileno($dh)], $buf, MSG_EOR);
+       if (!$n) {
+               die "sendmsg: $! (check RLIMIT_NOFILE)\n" if $!{ETOOMANYREFS};
+               die "sendmsg: $!\n";
+       }
+       1;
+}) { # connected and request sent to lei-daemon, wait for responses or EOF
        my $x_it_code = 0;
        while (1) {
-               my (@fds) = $recv_cmd->($sock, $buf, 4096 * 33);
+               my (@fds) = $recv_cmd->($sock, my $buf, 4096 * 33);
                if (scalar(@fds) == 1 && !defined($fds[0])) {
-                       last if $! == ECONNRESET;
-                       next if $! == EINTR;
+                       next if $!{EINTR};
+                       last if $!{ECONNRESET};
                        die "recvmsg: $!";
                }
                last if $buf eq '';
-               if ($buf =~ /\Ax_it ([0-9]+)\z/) {
+               if ($buf =~ /\Aexec (.+)\z/) {
+                       $exec_cmd->(\@fds, split(/\0/, $1));
+               } elsif ($buf eq '-WINCH') {
+                       kill($buf, $$); # for MUA
+               } elsif ($buf =~ /\Ax_it ([0-9]+)\z/) {
                        $x_it_code = $1 + 0;
                        last;
                } elsif ($buf =~ /\Achild_error ([0-9]+)\z/) {
                        $x_it_code = $1 + 0;
-               } elsif ($buf =~ /\Aexec (.+)\z/) {
-                       exec_cmd(\@fds, split(/\0/, $1));
                } else {
-                       sigchld();
+                       $sigchld->();
                        die $buf;
                }
        }
-       sigchld();
+       $sigchld->();
        if (my $sig = ($x_it_code & 127)) {
                kill $sig, $$;
-               sleep;
+               sleep(1) while 1;
        }
        exit($x_it_code >> 8);
 } else { # for systems lacking Socket::MsgHdr or Inline::C