doc: document the reason for --no-renumber

[public-inbox.git] / script / public-inbox-compact

diff --git a/script/public-inbox-compact b/script/public-inbox-compact
index 9f332657e3d3946989940e9d250d61f416ffaade..395eec37a4cff439cc2d1db1afbac81e9fb2fa95 100755 (executable)
--- a/script/public-inbox-compact
+++ b/script/public-inbox-compact
@@ -10,14 +10,17 @@ use PublicInbox::InboxWritable;
 use Cwd 'abs_path';
 use File::Temp qw(tempdir);
 use File::Path qw(remove_tree);
+use PublicInbox::Spawn qw(spawn);
 my $usage = "Usage: public-inbox-compact REPO_DIR\n";
 my $dir = shift or die $usage;
-my $config = PublicInbox::Config->new;
+my $config = eval { PublicInbox::Config->new };
 my $ibx;
 $dir = abs_path($dir);
-$config->each_inbox(sub {
-       $ibx = $_[0] if abs_path($_[0]->{mainrepo}) eq $dir
-});
+if ($config) {
+       $config->each_inbox(sub {
+               $ibx = $_[0] if abs_path($_[0]->{mainrepo}) eq $dir
+       });
+}
 unless ($ibx) {
        warn "W: $dir not configured in ".
                PublicInbox::Config::default_file() . "\n";
@@ -48,6 +51,8 @@ sub commit_changes ($$$) {
        $im->lock_release;
        remove_tree("$old/old") or die "failed to remove $old/old: $!\n";
 }
+
+# we rely on --no-renumber to keep docids synched to NNTP
 my @compact = qw(xapian-compact --no-renumber);
 if ($v == 2) {
        require PublicInbox::V2Writable;
@@ -58,10 +63,11 @@ if ($v == 2) {
        my $new = tempdir('compact-XXXXXXXX', CLEANUP => 1, DIR => $dir);
        $ibx->with_umask(sub {
                $v2w->lock_acquire;
-               my @parts;
+               my %pids;
                while (defined(my $dn = readdir($dh))) {
                        if ($dn =~ /\A\d+\z/) {
-                               push @parts, "$old/$dn";
+                               my $cmd = [ @compact, "$old/$dn", "$new/$dn" ];
+                               $pids{spawn($cmd)} = join(' ', @$cmd);
                        } elsif ($dn eq '.' || $dn eq '..') {
                        } elsif ($dn =~ /\Aover\.sqlite3/) {
                        } else {
@@ -69,9 +75,12 @@ if ($v == 2) {
                        }
                }
                close $dh;
-               die "No Xapian parts found in $old\n" unless @parts;
-               my $cmd = [@compact, @parts, "$new/0" ];
-               PublicInbox::Import::run_die($cmd);
+               die "No Xapian parts found in $old\n" unless keys %pids;
+               while (scalar keys %pids) {
+                       my $pid = waitpid(-1, 0);
+                       my $desc = delete $pids{$pid};
+                       die "$desc failed: $?\n" if $?;
+               }
                commit_changes($v2w, $old, $new);
        });
 } elsif ($v == 1) {