avoid potential UB when using isprint()

[st.git] / st.c

diff --git a/st.c b/st.c
index 51049ba22b86cb7f13d99b1c880504c0362ba320..1307fdf4ab3afee8d16af827b1a04a99152cf1ec 100644 (file)
--- a/st.c
+++ b/st.c
@@ -367,7 +367,7 @@ static const char base64_digits[] = {
 char
 base64dec_getc(const char **src)
 {
-       while (**src && !isprint(**src))
+       while (**src && !isprint((unsigned char)**src))
                (*src)++;
        return **src ? *((*src)++) : '=';  /* emulate padding if string ends */
 }
@@ -1927,7 +1927,7 @@ strhandle(void)
                        else if (xsetcolorname(defaultfg, p))
                                fprintf(stderr, "erresc: invalid foreground color: %s\n", p);
                        else
-                               redraw();
+                               tfulldirt();
                        return;
                case 11:
                        if (narg < 2)
@@ -1940,7 +1940,7 @@ strhandle(void)
                        else if (xsetcolorname(defaultbg, p))
                                fprintf(stderr, "erresc: invalid background color: %s\n", p);
                        else
-                               redraw();
+                               tfulldirt();
                        return;
                case 12:
                        if (narg < 2)
@@ -1953,7 +1953,7 @@ strhandle(void)
                        else if (xsetcolorname(defaultcs, p))
                                fprintf(stderr, "erresc: invalid cursor color: %s\n", p);
                        else
-                               redraw();
+                               tfulldirt();
                        return;
                case 4: /* color set */
                        if (narg < 3)
@@ -1975,7 +1975,7 @@ strhandle(void)
                                 * TODO if defaultbg color is changed, borders
                                 * are dirty
                                 */
-                               redraw();
+                               tfulldirt();
                        }
                        return;
                }