lei: test some likely errors due to misuse

[public-inbox.git] / t / lei.t

diff --git a/t/lei.t b/t/lei.t
index c4692217667f3ed4ea037abfe72fca6c2074e7f1..8bb4e439bfadbbc98171155e10a5317ab2528c20 100644 (file)
--- a/t/lei.t
+++ b/t/lei.t
@@ -181,6 +181,20 @@ my $test_external = sub {
        $lei->('ls-external');
        like($out, qr/boost=0\n/s, 'ls-external has output');
 
+       ok(!$lei->(qw(q s:prefix -o /dev/null -f maildir)), 'bad maildir');
+       like($err, qr!/dev/null exists and is not a directory!,
+               'error shown');
+       is($? >> 8, 1, 'errored out with exit 1');
+
+       ok(!$lei->(qw(q s:prefix -f mboxcl2 -o), $home), 'bad mbox');
+       like($err, qr!\Q$home\E exists and is not a regular file!,
+               'error shown');
+       is($? >> 8, 1, 'errored out with exit 1');
+
+       ok(!$lei->(qw(q s:prefix -o /dev/stdout -f Mbox2)), 'bad format');
+       like($err, qr/bad mbox --format=mbox2/, 'error shown');
+       is($? >> 8, 1, 'errored out with exit 1');
+
        # note, on a Bourne shell users should be able to use either:
        #       s:"use boolean prefix"
        #       "s:use boolean prefix"
@@ -189,25 +203,35 @@ my $test_external = sub {
        # No double-quoting should be imposed on users on the CLI
        $lei->('q', 's:use boolean prefix');
        like($out, qr/search: use boolean prefix/, 'phrase search got result');
+       require IO::Uncompress::Gunzip;
+       for my $sfx ('', '.gz') {
+               my $f = "$home/mbox$sfx";
+               $lei->('q', '-o', "mboxcl2:$f", 's:use boolean prefix');
+               my $cat = $sfx eq '' ? sub {
+                       open my $mb, '<', $f or fail "no mbox: $!";
+                       <$mb>
+               } : sub {
+                       my $z = IO::Uncompress::Gunzip->new($f, MultiStream=>1);
+                       <$z>;
+               };
+               my @s = grep(/^Subject:/, $cat->());
+               is(scalar(@s), 1, "1 result in mbox$sfx");
+               $lei->('q', '-a', '-o', "mboxcl2:$f", 's:see attachment');
+               is($err, '', 'no errors from augment');
+               @s = grep(/^Subject:/, my @wtf = $cat->());
+               is(scalar(@s), 2, "2 results in mbox$sfx");
 
-       $lei->('q', '-o', "mboxcl2:$home/mbox", 's:use boolean prefix');
-       open my $mb, '<', "$home/mbox" or fail "no mbox: $!";
-       my @s = grep(/^Subject:/, <$mb>);
-       is(scalar(@s), 1, '1 result in mbox');
-       $lei->('q', '-a', '-o', "mboxcl2:$home/mbox", 's:see attachment');
-       is($err, '', 'no errors from augment');
-       seek($mb, 0, SEEK_SET) or BAIL_OUT "seek: $!";
-       @s = grep(/^Subject:/, <$mb>);
-       is(scalar(@s), 2, '2 results in mbox');
+               $lei->('q', '-a', '-o', "mboxcl2:$f", 's:nonexistent');
+               is($err, '', "no errors on no results ($sfx)");
 
-       $lei->('q', '-a', '-o', "mboxcl2:$home/mbox", 's:nonexistent');
-       is($err, '', 'no errors on no results');
-       seek($mb, 0, SEEK_SET) or BAIL_OUT "seek: $!";
-       my @s2 = grep(/^Subject:/, <$mb>);
-       is_deeply(\@s2, \@s, 'same 2 old results w/ --augment and bad search');
+               my @s2 = grep(/^Subject:/, $cat->());
+               is_deeply(\@s2, \@s,
+                       "same 2 old results w/ --augment and bad search $sfx");
 
-       $lei->('q', '-o', "mboxcl2:$home/mbox", 's:nonexistent');
-       is(-s "$home/mbox", 0, 'clobber w/o --augment');
+               $lei->('q', '-o', "mboxcl2:$f", 's:nonexistent');
+               my @res = $cat->();
+               is_deeply(\@res, [], "clobber w/o --augment $sfx");
+       }
 };
 
 my $test_lei_common = sub {
@@ -224,18 +248,14 @@ if ($ENV{TEST_LEI_ONESHOT}) {
        local $ENV{XDG_RUNTIME_DIR} = $xrd;
        $err_filter = qr!\Q$xrd!;
        $test_lei_common->();
-}
-
+} else {
 SKIP: { # real socket
-       require_mods(qw(Cwd), my $nr = 105);
-       my $nfd = eval { require Socket::MsgHdr; 5 } // do {
+       eval { require Socket::MsgHdr; 1 } // do {
                require PublicInbox::Spawn;
-               PublicInbox::Spawn->can('send_cmd4') ? 5 : undef;
-       } //
-       skip 'Socket::MsgHdr or Inline::C missing or unconfigured', $nr;
-
+               PublicInbox::Spawn->can('send_cmd4');
+       } // skip 'Socket::MsgHdr or Inline::C missing or unconfigured', 115;
        local $ENV{XDG_RUNTIME_DIR} = "$home/xdg_run";
-       my $sock = "$ENV{XDG_RUNTIME_DIR}/lei/$nfd.seq.sock";
+       my $sock = "$ENV{XDG_RUNTIME_DIR}/lei/5.seq.sock";
 
        ok($lei->('daemon-pid'), 'daemon-pid');
        is($err, '', 'no error from daemon-pid');
@@ -287,6 +307,7 @@ SKIP: { # real socket
        }
        ok(!kill(0, $new_pid), 'daemon exits after unlink');
        # success over socket, can't test without
-};
+}; # SKIP
+} # else
 
 done_testing;