tests: rely on PublicInbox::Git for pathname safety

[public-inbox.git] / t / plack.t

diff --git a/t/plack.t b/t/plack.t
index 14c9b657f50cb5db1d3758ab693b89cfc533b484..9308813f2228f6182ac29cf2baf5710dfd5cc888 100644 (file)
--- a/t/plack.t
+++ b/t/plack.t
@@ -1,4 +1,4 @@
-# Copyright (C) 2014-2018 all contributors <meta@public-inbox.org>
+# Copyright (C) 2014-2019 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
 use warnings;
@@ -29,7 +29,7 @@ foreach my $mod (@mods) { use_ok $mod; }
        close $fh or die "close: $!\n";
        my %cfg = (
                "$cfgpfx.address" => $addr,
-               "$cfgpfx.mainrepo" => $maindir,
+               "$cfgpfx.inboxdir" => $maindir,
                "$cfgpfx.url" => 'http://example.com/test/',
                "$cfgpfx.newsgroup" => 'inbox.test',
        );
@@ -46,7 +46,7 @@ To: You <you\@example.com>
 Cc: $addr
 Message-Id: <blah\@example.com>
 Subject: hihi
-Date: Thu, 01 Jan 1970 00:00:00 +0000
+Date: Fri, 02 Oct 1993 00:00:00 +0000
 
 zzzzzz
 EOF
@@ -54,9 +54,9 @@ EOF
                my $im = PublicInbox::Import->new($git, 'test', $addr);
                $im->add($mime);
                $im->done;
-               my $rev = `git --git-dir="$maindir" rev-list HEAD`;
+               my $rev = $git->qx(qw(rev-list HEAD));
                like($rev, qr/\A[a-f0-9]{40}/, "good revision committed");
-               @ls = `git --git-dir="$maindir" ls-tree -r --name-only HEAD`;
+               @ls = $git->qx(qw(ls-tree -r --name-only HEAD));
                chomp @ls;
        }
        my $app = eval {
@@ -129,6 +129,7 @@ EOF
                        'atom URL generated');
                like($res->content, qr!href="blah\@example\.com/"!,
                        'index generated');
+               like($res->content, qr!1993-10-02!, 'date set');
        });
 
        test_psgi($app, sub {
@@ -240,6 +241,19 @@ EOF
                is(206, $res->code, 'got partial another response');
                is($res->content, substr($orig, 5), 'partial body OK past end');
        });
+
+       # things which should fail
+       test_psgi($app, sub {
+               my ($cb) = @_;
+
+               my $res = $cb->(PUT('/'));
+               is(405, $res->code, 'no PUT to / allowed');
+               $res = $cb->(PUT('/test/'));
+               is(405, $res->code, 'no PUT /$INBOX allowed');
+
+               # TODO
+               # $res = $cb->(GET('/'));
+       });
 }
 
 done_testing();