search: avoid creating ghosts for circular References

[public-inbox.git] / t / search.t

diff --git a/t/search.t b/t/search.t
index 9bdd3cee9964ae0ca03d1b97095a5cca3e79f52f..55abe9e8bdd083d10105168731ae96f56aabcc55 100644 (file)
--- a/t/search.t
+++ b/t/search.t
@@ -3,8 +3,9 @@
 use strict;
 use warnings;
 use Test::More;
+eval { require PublicInbox::Search; };
+plan skip_all => "Xapian missing for search" if $@;
 use File::Temp qw/tempdir/;
-use PublicInbox::Search;
 use Email::MIME;
 use Data::Dumper;
 my $tmpdir = tempdir(CLEANUP => 1);
@@ -17,6 +18,10 @@ ok($@, "exception raised on non-existent DB");
 
 my $rw = PublicInbox::Search->new($git_dir, 1);
 my $ro = PublicInbox::Search->new($git_dir);
+my $rw_commit = sub {
+       $rw = undef;
+       $rw = PublicInbox::Search->new($git_dir, 1);
+};
 
 {
        my $root = Email::MIME->create(
@@ -52,6 +57,7 @@ sub filter_mids {
 }
 
 {
+       $rw_commit->();
        $ro->reopen;
        my $found = $ro->lookup_message('<root@s>');
        ok($found, "message found");
@@ -100,7 +106,7 @@ sub filter_mids {
 
 # ghost vivication
 {
-       $rw->reopen;
+       $rw_commit->();
        my $rmid = '<ghost-message@s>';
        my $reply_to_ghost = Email::MIME->create(
                header_str => [
@@ -134,6 +140,7 @@ sub filter_mids {
 
 # search thread on ghost
 {
+       $rw_commit->();
        $ro->reopen;
 
        # Subject:
@@ -149,7 +156,7 @@ sub filter_mids {
 
 # long message-id
 {
-       $rw->reopen;
+       $rw_commit->();
        $ro->reopen;
        my $long_mid = 'last' . ('x' x 60). '@s';
        my $long_midc = Digest::SHA::sha1_hex($long_mid);
@@ -168,15 +175,16 @@ sub filter_mids {
        my $long_id = $rw->add_message($long);
        is($long_id, int($long_id), "long_id is an integer: $long_id");
 
+       $rw_commit->();
        $ro->reopen;
        my $res = $ro->query('references:root@s');
        my @res = filter_mids($res);
        is_deeply(\@res, [ sort('last@s', $long_midc) ],
                  "got expected results for references: match");
 
-       my $replies = $ro->get_replies('root@s');
-       $replies = [ filter_mids($replies) ];
-       is_deeply($replies, [ filter_mids($res) ], "get_replies matches");
+       my $followups = $ro->get_followups('root@s');
+       $followups = [ filter_mids($followups) ];
+       is_deeply($followups, [ filter_mids($res) ], "get_followups matches");
 
        my $long_reply_mid = 'reply-to-long@1';
        my $long_reply = Email::MIME->create(
@@ -193,6 +201,7 @@ sub filter_mids {
                body => "no References\n");
        ok($rw->add_message($long_reply) > $long_id, "inserted long reply");
 
+       $rw_commit->();
        $ro->reopen;
        my $t = $ro->get_thread('root@s');
        is($t->{count}, 4, "got all 4 mesages in thread");
@@ -203,7 +212,7 @@ sub filter_mids {
 
 # quote prioritization
 {
-       $rw->reopen;
+       $rw_commit->();
        $rw->add_message(Email::MIME->create(
                header_str => [
                        Date => 'Sat, 02 Oct 2010 00:00:01 +0000',
@@ -234,6 +243,25 @@ sub filter_mids {
                "quoted result returned if nothing else");
 }
 
+# circular references
+{
+       my $doc_id = $rw->add_message(Email::MIME->create(
+               header_str => [
+                       Date => 'Sat, 02 Oct 2010 00:00:01 +0000',
+                       Subject => 'Circle',
+                       'Message-ID' => '<circle@a>',
+                       'References' => '<circle@a>',
+                       'In-Reply-To' => '<circle@a>',
+                       From => 'Circle <circle@example.com>',
+                       To => 'list@example.com',
+               ],
+               body => "LOOP!\n"));
+       ok($doc_id > 0, "doc_id defined with circular reference");
+       my $smsg = $rw->lookup_message('circle@a');
+       $smsg->ensure_metadata;
+       is($smsg->{references}, undef, "no references created");
+}
+
 done_testing();
 
 1;