www_coderepo: quiet 404s on Atom feeds for dead branches

[public-inbox.git] / t / solver_git.t

diff --git a/t/solver_git.t b/t/solver_git.t
index 8faa7309fcd5f0152ab7561582fc5e32598fd6ab..79672398f88cfe9fcdbad92629f68136eda7d2cc 100644 (file)
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -293,7 +293,7 @@ EOF
                is($res->code, 404, 'failure with null OID');
 
                $res = $cb->(GET("/$name/$non_existent/s/"));
-               is($res->code, 404, 'failure with null OID');
+               is($res->code, 404, 'failure with non-existent OID');
 
                $res = $cb->(GET("/$name/$v1_0_0_tag/s/"));
                is($res->code, 200, 'shows commit (unabbreviated)');
@@ -336,7 +336,7 @@ EOF
                        open $fh, '>', "$tmpdir/stderr.log" or xbail $!;
                        ok($s =~ s/^fatal: your current branch.*?\n//sm,
                                'got current branch warning');
-                       ok($s =~ s/^.*? exit status=[1-9]+ .*?\n//sm,
+                       ok($s =~ s/^.*? exit status=[1-9]+\n\z//sm,
                                'got exit status warning');
                        is($s, '', 'no unexpected warnings on empty coderepo');
                }
@@ -379,7 +379,10 @@ EOF
                        ok($t->{feed}->{entry}, 'got entry');
 
                        $res = $cb->(GET('/public-inbox/atom/README.md'));
-                       is($res->code, 404, '404 on non-existent file Atom feed');
+                       is($res->code, 404, '404 on missing file Atom feed');
+
+                       $res = $cb->(GET('/public-inbox/atom/?h=gone'));
+                       is($res->code, 404, '404 on missing Atom feed branch');
                }
 
                $res = $cb->(GET('/public-inbox/tree/'));
@@ -396,6 +399,21 @@ EOF
                is($res->code, 200, 'got 200 for a directory');
                $got = $res->content;
                like($got, qr/\bgit ls-tree\b/, 'ls-tree help shown');
+
+               $res = $cb->(GET('/public-inbox/tree/?h=no-branch'));
+               is($res->code, 404, 'got 404 for non-existent ref root');
+               $res = $cb->(GET('/public-inbox/tree/README?h=no-file'));
+               is($res->code, 404, 'got 404 for non-existent ref README');
+               $res = $cb->(GET('/public-inbox/tree/Documentation?h=no-dir'));
+               is($res->code, 404, 'got 404 for non-existent ref directory');
+
+               $res = $cb->(GET('/public-inbox/tags.atom'));
+               is($res->code, 200, 'Atom feed');
+               SKIP: {
+                       require_mods('XML::TreePP', 1);
+                       my $t = XML::TreePP->new->parse($res->content);
+                       ok(scalar @{$t->{feed}->{entry}}, 'got tag entries');
+               }
        };
        test_psgi(sub { $www->call(@_) }, $client);
        my $env = { PI_CONFIG => $cfgpath, TMPDIR => $tmpdir };