net_reader: fix single NNTP article fetch, test ranges

[public-inbox.git] / t / v2mirror.t

diff --git a/t/v2mirror.t b/t/v2mirror.t
index ebad2566605a79dbbc25d2689e67deba4564da66..665a4d594f93e445f07cd96fa9a73595e2763ca2 100644 (file)
--- a/t/v2mirror.t
+++ b/t/v2mirror.t
@@ -1,19 +1,17 @@
 # Copyright (C) 2018-2021 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
-use warnings;
-use Test::More;
+use v5.10.1;
 use PublicInbox::TestCommon;
-use File::Path qw(remove_tree);
+use File::Path qw(remove_tree make_path);
 use Cwd qw(abs_path);
 require_git(2.6);
+require_cmd('curl');
 local $ENV{HOME} = abs_path('t');
 
 # Integration tests for HTTP cloning + mirroring
 require_mods(qw(Plack::Util Plack::Builder
                HTTP::Date HTTP::Status Search::Xapian DBD::SQLite));
-use IO::Socket;
-use POSIX qw(dup2);
 use_ok 'PublicInbox::V2Writable';
 use PublicInbox::InboxWritable;
 use PublicInbox::Eml;
@@ -36,6 +34,7 @@ my $cfg = PublicInbox::Config->new($pi_config);
 my $ibx = $cfg->lookup('test@example.com');
 ok($ibx, 'inbox found');
 $ibx->{version} = 2;
+$ibx->{-no_fsync} = 1;
 my $v2w = PublicInbox::V2Writable->new($ibx, 1);
 ok $v2w, 'v2w loaded';
 $v2w->{parallel} = 0;
@@ -64,21 +63,16 @@ $v2w->done;
 $ibx->cleanup;
 
 my $sock = tcp_server();
-ok($sock, 'sock created');
-my $cmd = [ '-httpd', '-W0', "--stdout=$tmpdir/out", "--stderr=$tmpdir/err" ];
-my $td = start_script($cmd, undef, { 3 => $sock });
-my ($host, $port) = ($sock->sockhost, $sock->sockport);
+my @cmd = ('-httpd', '-W0', "--stdout=$tmpdir/out", "--stderr=$tmpdir/err");
+my $td = start_script(\@cmd, undef, { 3 => $sock });
+my ($host, $port) = tcp_host_port($sock);
 $sock = undef;
 
-my @cmd;
-foreach my $i (0..$epoch_max) {
-       my $sfx = $i == 0 ? '.git' : '';
-       @cmd = (qw(git clone --mirror -q),
-               "http://$host:$port/v2/$i$sfx",
-               "$tmpdir/m/git/$i.git");
+@cmd = (qw(-clone -q), "http://$host:$port/v2/", "$tmpdir/m");
+run_script(\@cmd) or xbail '-clone';
 
-       is(xsys(@cmd), 0, "cloned $i.git");
-       ok(-d "$tmpdir/m/git/$i.git", "mirror $i OK");
+for my $i (0..$epoch_max) {
+       ok(-d "$tmpdir/m/git/$i.git", "epoch $i cloned");
 }
 
 @cmd = ("-init", '-j1', '-V2', 'm', "$tmpdir/m", 'http://example.com/m',
@@ -93,7 +87,6 @@ my $mibx = { inboxdir => "$tmpdir/m", address => 'alt@example.com' };
 $mibx = PublicInbox::Inbox->new($mibx);
 is_deeply([$mibx->mm->minmax], [$ibx->mm->minmax], 'index synched minmax');
 
-$v2w->{rotate_bytes} = $old_rotate_bytes;
 for my $i (10..15) {
        $mime->header_set('Message-ID', "<$i\@example.com>");
        $mime->header_set('Subject', "subject = $i");
@@ -102,12 +95,14 @@ for my $i (10..15) {
 $v2w->done;
 $ibx->cleanup;
 
+my @new_epochs;
 my $fetch_each_epoch = sub {
-       foreach my $i (0..$epoch_max) {
-               my $dir = "$tmpdir/m/git/$i.git";
-               is(xsys('git', "--git-dir=$dir", 'fetch', '-q'), 0,
-                       'fetch successful');
-       }
+       my %before = map { $_ => 1 } glob("$tmpdir/m/git/*");
+       run_script([qw(-fetch --exit-code -q)], undef, {-C => "$tmpdir/m"}) or
+               xbail '-fetch fail';
+       is($?, 0, '--exit-code 0 after fetch updated');
+       my @after = grep { !$before{$_} } glob("$tmpdir/m/git/*");
+       push @new_epochs, @after;
 };
 
 $fetch_each_epoch->();
@@ -233,10 +228,42 @@ EOF
        $mset = $mibx->search->reopen->mset('m:2big@a');
        is(scalar($mset->items), 0, 'large message not re-indexed');
 }
+ok(scalar(@new_epochs), 'new epochs were created and fetched');
+for my $d (@new_epochs) {
+       is(xqx(['git', "--git-dir=$d", 'config', qw(include.path)]),
+               "../../all.git/config\n",
+               'include.path set');
+}
+
+if ('test read-only epoch dirs') {
+       my @git = ('git', "--git-dir=$new_epochs[0]");
+       my $get_objs = [@git,
+               qw(cat-file --buffer --batch-check --batch-all-objects)];
+       my $before = [sort xqx($get_objs)];
+
+       remove_tree(map { "$new_epochs[0]/$_" } qw(objects refs/heads));
+       chmod(0555, $new_epochs[0]) or xbail "chmod: $!";
+
+       # force a refetch
+       unlink("$tmpdir/m/manifest.js.gz") or xbail "unlink: $!";
+
+       run_script([qw(-fetch -q)], undef, {-C => "$tmpdir/m"}) or
+               xbail '-fetch failed';
+
+       ok(!-d "$new_epochs[0]/objects", 'no objects after fetch to R/O dir');
+
+       chmod(0755, $new_epochs[0]) or xbail "chmod: $!";
+       mkdir("$new_epochs[0]/objects") or xbail "mkdir: $!";
+       mkdir("$new_epochs[0]/refs/heads") or xbail "mkdir: $!";
+
+       my $err = '';
+       run_script([qw(-fetch -q)], undef, {-C => "$tmpdir/m", 2 => \$err}) or
+               xbail '-fetch failed '.$err;
+       is_deeply([ sort xqx($get_objs) ], $before,
+               'fetch restored objects once GIT_DIR became writable');
+}
 
 ok($td->kill, 'killed httpd');
 $td->join;
 
-done_testing();
-
-1;
+done_testing;