view: msg_html uses getline body to reduce latency

[public-inbox.git] / t / view.t

diff --git a/t/view.t b/t/view.t
index 1a47416faaef9944f80494b22d90360e3229bc9d..6c0859915e89c9ae2d1384d69c2bd35a5c8d5ed0 100644 (file)
--- a/t/view.t
+++ b/t/view.t
@@ -6,6 +6,18 @@ use Test::More;
 use Email::MIME;
 use PublicInbox::View;
 
+sub msg_html ($) {
+       my ($mime) = @_;
+
+       my $s = '';
+       my $body = PublicInbox::View::msg_html(undef, $mime);
+       while (defined(my $buf = $body->getline)) {
+               $s .= $buf;
+       }
+       $body->close;
+       $s;
+}
+
 # plain text
 {
        my $body = <<EOF;
@@ -41,7 +53,7 @@ EOF
                body => $body,
        )->as_string;
        my $mime = Email::MIME->new($s);
-       my $html = PublicInbox::View::msg_html(undef, $mime);
+       my $html = msg_html($mime);
 
        # ghetto tests
        like($html, qr!<a\nhref="raw"!s, "raw link present");
@@ -71,8 +83,8 @@ EOF
                parts => $parts,
        );
 
-       my $html = PublicInbox::View::msg_html(undef, $mime);
-       like($html, qr/hi\n-+ part #2 -+\nbye\n/, "multipart split");
+       my $html = msg_html($mime);
+       like($html, qr/hi\n.*-- Attachment #2.*\nbye\n/s, "multipart split");
 }
 
 # multipart email with attached patch
@@ -100,8 +112,8 @@ EOF
                parts => $parts,
        );
 
-       my $html = PublicInbox::View::msg_html(undef, $mime);
-       like($html, qr!see attached patch\n-+ foo\.patch -+\n--- a/file\n!,
+       my $html = msg_html($mime);
+       like($html, qr!.*Attachment #2: foo\.patch --!,
                "parts split with filename");
 }
 
@@ -126,15 +138,18 @@ EOF
        );
 
        my $orig = $mime->body_raw;
-       my $html = PublicInbox::View::msg_html(undef, $mime);
+       my $html = msg_html($mime);
        like($orig, qr/hi =3D bye=/, "our test used QP correctly");
        like($html, qr/\bhi = bye\b/, "HTML output decoded QP");
 }
 
 {
        use PublicInbox::MID qw/id_compress/;
+
+       # n.b: this is probably invalid since we dropped CGI for PSGI:
        like(id_compress('foo%bar@wtf'), qr/\A[a-f0-9]{40}\z/,
                "percent always converted to sha1 to workaround buggy httpds");
+
        is(id_compress('foobar-wtf'), 'foobar-wtf',
                'regular ID not compressed');
 }