view: msg_html uses getline body to reduce latency

[public-inbox.git] / t / view.t

diff --git a/t/view.t b/t/view.t
index fbdbd88433fa48d1716043c51f7edac8fbb7721e..6c0859915e89c9ae2d1384d69c2bd35a5c8d5ed0 100644 (file)
--- a/t/view.t
+++ b/t/view.t
@@ -1,4 +1,4 @@
-# Copyright (C) 2013, Eric Wong <normalperson@yhbt.net> and all contributors
+# Copyright (C) 2013-2015 all contributors <meta@public-inbox.org>
 # License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt)
 use strict;
 use warnings;
@@ -6,6 +6,18 @@ use Test::More;
 use Email::MIME;
 use PublicInbox::View;
 
+sub msg_html ($) {
+       my ($mime) = @_;
+
+       my $s = '';
+       my $body = PublicInbox::View::msg_html(undef, $mime);
+       while (defined(my $buf = $body->getline)) {
+               $s .= $buf;
+       }
+       $body->close;
+       $s;
+}
+
 # plain text
 {
        my $body = <<EOF;
@@ -16,6 +28,17 @@ OK
 
 > Long and wordy reply goes here and it is split across multiple lines.
 > We generate links to a separate full page where quoted-text is inline.
+> This is
+>
+> Currently 12 lines
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
+> See MAX_INLINE_QUOTED
 
 hello world
 EOF
@@ -28,25 +51,14 @@ EOF
                        Subject => 'this is a subject',
                ],
                body => $body,
-       );
-       $s = Email::MIME->new($s->as_string);
-       my $html = PublicInbox::View->as_html($s);
+       )->as_string;
+       my $mime = Email::MIME->new($s);
+       my $html = msg_html($mime);
 
-       # ghetto
-       like($html, qr/<a href="?hello%40/s, "MID link present");
+       # ghetto tests
+       like($html, qr!<a\nhref="raw"!s, "raw link present");
        like($html, qr/hello world\b/, "body present");
        like($html, qr/&gt; keep this inline/, "short quoted text is inline");
-       like($html, qr/<a name=[^>]+>&gt; Long and wordy/,
-               "long quoted text is anchored");
-
-       # short page
-       my $pfx = "http://example.com/test/full";
-       my $short = PublicInbox::View->as_html($s, $pfx);
-       like($short, qr/\n&gt; keep this inline/,
-               "short quoted text is inline");
-       like($short, qr/<a href=\Q$pfx\E#[^>]+>Long and wordy/,
-               "long quoted text is made into a link");
-       ok(length($short) < length($html), "short page is shorter");
 }
 
 # multipart crap
@@ -71,8 +83,8 @@ EOF
                parts => $parts,
        );
 
-       my $html = PublicInbox::View->as_html($mime);
-       like($html, qr/hi\n-+ part #2 -+\nbye\n/, "multipart split");
+       my $html = msg_html($mime);
+       like($html, qr/hi\n.*-- Attachment #2.*\nbye\n/s, "multipart split");
 }
 
 # multipart email with attached patch
@@ -100,9 +112,46 @@ EOF
                parts => $parts,
        );
 
-       my $html = PublicInbox::View->as_html($mime);
-       like($html, qr!see attached patch\n-+ foo\.patch -+\n--- a/file\n!,
+       my $html = msg_html($mime);
+       like($html, qr!.*Attachment #2: foo\.patch --!,
                "parts split with filename");
 }
 
+# multipart collapsed to single quoted-printable text/plain
+{
+       my $parts = [
+               Email::MIME->create(
+                       attributes => {
+                               content_type => 'text/plain',
+                               encoding => 'quoted-printable',
+                       },
+                       body => 'hi = bye',
+               )
+       ];
+       my $mime = Email::MIME->create(
+               header_str => [
+                       From => 'qp@example.com',
+                       Subject => 'QP',
+                       'Message-ID' => '<qp@example.com>',
+                       ],
+               parts => $parts,
+       );
+
+       my $orig = $mime->body_raw;
+       my $html = msg_html($mime);
+       like($orig, qr/hi =3D bye=/, "our test used QP correctly");
+       like($html, qr/\bhi = bye\b/, "HTML output decoded QP");
+}
+
+{
+       use PublicInbox::MID qw/id_compress/;
+
+       # n.b: this is probably invalid since we dropped CGI for PSGI:
+       like(id_compress('foo%bar@wtf'), qr/\A[a-f0-9]{40}\z/,
+               "percent always converted to sha1 to workaround buggy httpds");
+
+       is(id_compress('foobar-wtf'), 'foobar-wtf',
+               'regular ID not compressed');
+}
+
 done_testing();