]> Sergey Matveev's repositories - public-inbox.git/commitdiff
config: do not implicitly set coderepo.*.cgiturl
authorEric Wong <e@80x24.org>
Sun, 8 Jan 2023 08:04:12 +0000 (08:04 +0000)
committerEric Wong <e@80x24.org>
Sun, 8 Jan 2023 17:49:28 +0000 (17:49 +0000)
It's a needless waste of memory and this change reduces the
WwwCoderepo object size by over 25% with over 1K repos.
Using the following check:

  perl -MDevel::Size=total_size -I lib -MPublicInbox::WwwCoderepo -E \
  'say total_size(PublicInbox::WwwCoderepo->new(PublicInbox::Config->new))'

before: 1612515
 after: 1184385

lib/PublicInbox/Config.pm

index 174c75efcfe2a862b5585799bb061f5646364fb9..c48ab2bd5c43c0c85d7c87fabf71782a2fe5c478 100644 (file)
@@ -226,7 +226,6 @@ sub cgit_repo_merge ($$$) {
                        $rel =~ s!/?\.git\z!!;
        }
        $self->{"coderepo.$rel.dir"} //= $path;
                        $rel =~ s!/?\.git\z!!;
        }
        $self->{"coderepo.$rel.dir"} //= $path;
-       $self->{"coderepo.$rel.cgiturl"} //= _array($rel);
 }
 
 sub is_git_dir ($) {
 }
 
 sub is_git_dir ($) {