search: don't log all warnings on retry_reopen

Some users (or bots :P) can trigger horrible queries which
the caller can choose to either log or ignore.  This prevents
horrible queries from ExtMsg from logging confusing "ref: "
messages when $@ is not a Perl reference.

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index d861cf471932aacddff0915f6ede3e8ec103fd6e..c054a87497c400f3a2b2053b94f828eff78400d0 100644 (file)
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -228,7 +228,9 @@ sub retry_reopen {
                        warn "reopen try #$i on $@\n";
                        reopen($self);
                } else {
-                       warn "ref: ", ref($@), "\n";
+                       # let caller decide how to spew, because ExtMsg queries
+                       # get wonky and trigger:
+                       # "something terrible happened at .../Xapian/Enquire.pm"
                        die;
                }
        }