]> Sergey Matveev's repositories - public-inbox.git/commitdiff
lei: use open() perlop for -C (chdir)
authorEric Wong <e@80x24.org>
Tue, 22 Jun 2021 10:04:36 +0000 (10:04 +0000)
committerEric Wong <e@80x24.org>
Tue, 22 Jun 2021 18:54:28 +0000 (18:54 +0000)
This is for consistency with the open() at initial accept, in
case we hit a code path which expects Perl directory handles
rather than "file handles".  Both work with the chdir() perlop
(fchdir(2), in our case).

lib/PublicInbox/LEI.pm

index 546fa773fc4c334cc83a27358ba74f016cf62dab..cffe4dceec95c342dd3bef782c9d342e1eb6574c 100644 (file)
@@ -762,11 +762,7 @@ sub dispatch {
                                next if $d eq ''; # same as git(1)
                                chdir $d or return fail($self, "cd $d: $!");
                        }
-                       if (delete $self->{3}) { # update cwd for rel2abs
-                               opendir my $dh, '.' or
-                                       return fail($self, "opendir . $!");
-                               $self->{3} = $dh;
-                       }
+                       open $self->{3}, '.' or return fail($self, "open . $!");
                }
                $cb->($self, @argv);
        } elsif (grep(/\A-/, $cmd, @argv)) { # --help or -h only