]> Sergey Matveev's repositories - public-inbox.git/commitdiff
unsubscribe: HTML encode undecryptable username
authorEric Wong <e@80x24.org>
Fri, 10 Jun 2016 07:23:24 +0000 (07:23 +0000)
committerEric Wong <e@80x24.org>
Fri, 10 Jun 2016 07:24:11 +0000 (07:24 +0000)
Otherwise, URLs can be crafted to inject HTML.

lib/PublicInbox/Unsubscribe.pm

index 95348ea318f1d184c5876e9fe94f0b8fabdb155f..239feea9d9311c9e496036e80354809b71aeb22c 100644 (file)
@@ -82,6 +82,7 @@ sub _user_list_addr {
                my $errors = $env->{'psgi.errors'};
                $errors->print("error decrypting: $u\n");
                $errors->print("$_\n") for split("\n", $err);
+               $u = Plack::Util::encode_html($u);
                return r($self, 400, 'Bad request', "Failed to decrypt: $u");
        }