]> Sergey Matveev's repositories - btrtrc.git/log
btrtrc.git
8 years agoUse metainfo.Hash for piece and info hashes
Matt Joiner [Mon, 4 Apr 2016 03:01:31 +0000 (13:01 +1000)]
Use metainfo.Hash for piece and info hashes

8 years agoAdding a torrent without info after waitAccept has blocked wouldn't trigger further...
Matt Joiner [Sun, 3 Apr 2016 12:06:25 +0000 (22:06 +1000)]
Adding a torrent without info after waitAccept has blocked wouldn't trigger further accepts immediately

8 years agoFix deadlocks in WriteStatus due to incomplete renaming
Matt Joiner [Sun, 3 Apr 2016 10:54:14 +0000 (20:54 +1000)]
Fix deadlocks in WriteStatus due to incomplete renaming

8 years agoMerge Torrent and torrent types
Matt Joiner [Sun, 3 Apr 2016 08:40:43 +0000 (18:40 +1000)]
Merge Torrent and torrent types

8 years agoComments
Matt Joiner [Sun, 3 Apr 2016 06:52:52 +0000 (16:52 +1000)]
Comments

8 years agoMake everything on type torrent private
Matt Joiner [Sun, 3 Apr 2016 06:50:53 +0000 (16:50 +1000)]
Make everything on type torrent private

8 years agopiece file storage: Don't write to completed pieces
Matt Joiner [Sun, 3 Apr 2016 06:37:50 +0000 (16:37 +1000)]
piece file storage: Don't write to completed pieces

8 years agocmd/torrent-metainfo-pprint: Switch to tagflag for argument parsing
Matt Joiner [Sun, 3 Apr 2016 06:37:17 +0000 (16:37 +1000)]
cmd/torrent-metainfo-pprint: Switch to tagflag for argument parsing

8 years agoIf we fail to write to a piece, check its completion state
Matt Joiner [Sun, 3 Apr 2016 06:36:57 +0000 (16:36 +1000)]
If we fail to write to a piece, check its completion state

8 years agoImprove log messages
Matt Joiner [Sun, 3 Apr 2016 06:36:24 +0000 (16:36 +1000)]
Improve log messages

8 years agoSuppress piece read errors when data is obtained
Matt Joiner [Sun, 3 Apr 2016 06:35:28 +0000 (16:35 +1000)]
Suppress piece read errors when data is obtained

8 years agostorage: Don't read bad completed piece files
Matt Joiner [Sun, 3 Apr 2016 06:33:31 +0000 (16:33 +1000)]
storage: Don't read bad completed piece files

8 years agostorage: Fix io.EOF on short piece files
Matt Joiner [Sat, 2 Apr 2016 05:57:22 +0000 (16:57 +1100)]
storage: Fix io.EOF on short piece files

8 years agoMissing error checks in test
Matt Joiner [Wed, 30 Mar 2016 08:16:40 +0000 (19:16 +1100)]
Missing error checks in test

8 years agoSuppress logging noise in tests
Matt Joiner [Wed, 30 Mar 2016 08:12:57 +0000 (19:12 +1100)]
Suppress logging noise in tests

8 years agoMove storage.FileStore interface to missinggo
Matt Joiner [Wed, 30 Mar 2016 08:12:33 +0000 (19:12 +1100)]
Move storage.FileStore interface to missinggo

8 years agoFix missinggo import
Matt Joiner [Wed, 30 Mar 2016 08:11:55 +0000 (19:11 +1100)]
Fix missinggo import

8 years agoFew fixes for downstream projects
Matt Joiner [Tue, 29 Mar 2016 01:13:03 +0000 (12:13 +1100)]
Few fixes for downstream projects

8 years agoRemove all the old data store packages
Matt Joiner [Tue, 29 Mar 2016 00:14:54 +0000 (11:14 +1100)]
Remove all the old data store packages

8 years agoReimplement piece storage
Matt Joiner [Tue, 29 Mar 2016 00:14:34 +0000 (11:14 +1100)]
Reimplement piece storage

8 years agoFinish fixing tests
Matt Joiner [Mon, 28 Mar 2016 13:24:00 +0000 (00:24 +1100)]
Finish fixing tests

8 years agoMake opening a torrent in storage an explicit method
Matt Joiner [Mon, 28 Mar 2016 11:40:29 +0000 (22:40 +1100)]
Make opening a torrent in storage an explicit method

This is storage types where opening can fail, like mmap

8 years agoGet mmap storage working
Matt Joiner [Mon, 28 Mar 2016 10:57:04 +0000 (21:57 +1100)]
Get mmap storage working

8 years agoNew storage interface
Matt Joiner [Mon, 28 Mar 2016 09:38:30 +0000 (20:38 +1100)]
New storage interface

8 years agodata/file: Rewrite ReadAt
Matt Joiner [Sat, 26 Mar 2016 09:45:31 +0000 (20:45 +1100)]
data/file: Rewrite ReadAt

8 years agodata/file: Add a test checking for io.ErrUnexpectedEOF on short read
Matt Joiner [Sat, 26 Mar 2016 07:30:30 +0000 (18:30 +1100)]
data/file: Add a test checking for io.ErrUnexpectedEOF on short read

8 years agoImprove doc comments on Data
Matt Joiner [Sat, 26 Mar 2016 07:27:28 +0000 (18:27 +1100)]
Improve doc comments on Data

8 years agoTidy up a test that fails with the wrong reasons
Matt Joiner [Thu, 24 Mar 2016 12:52:38 +0000 (23:52 +1100)]
Tidy up a test that fails with the wrong reasons

8 years agoTidy up bytesLeft calculations
Matt Joiner [Tue, 22 Mar 2016 02:11:36 +0000 (13:11 +1100)]
Tidy up bytesLeft calculations

This should fix a bug where completion is shown as negative in WriteStatus

8 years agoLog connection errors when debug mode
Matt Joiner [Tue, 22 Mar 2016 02:10:18 +0000 (13:10 +1100)]
Log connection errors when debug mode

8 years agoAdd a test for bad have messages
Matt Joiner [Tue, 22 Mar 2016 02:09:02 +0000 (13:09 +1100)]
Add a test for bad have messages

The reason for the cleanup to peer have-related messages in the first place.

8 years agoTidy up the peer have{,all,none},bitfield handling
Matt Joiner [Tue, 22 Mar 2016 01:07:03 +0000 (12:07 +1100)]
Tidy up the peer have{,all,none},bitfield handling

8 years agoAdd t.bytesLeftAnnounce
Matt Joiner [Mon, 21 Mar 2016 22:06:48 +0000 (09:06 +1100)]
Add t.bytesLeftAnnounce

Now it's safe to remove tracker specific bytesLeft contract

8 years agoClient.WriteStatus: Raise the precision of the completion percentage
Matt Joiner [Mon, 21 Mar 2016 21:33:08 +0000 (08:33 +1100)]
Client.WriteStatus: Raise the precision of the completion percentage

8 years agoUse missinggo.AddrPort directly
Matt Joiner [Mon, 21 Mar 2016 05:02:36 +0000 (16:02 +1100)]
Use missinggo.AddrPort directly

8 years agoMake peerGotPiece a method on connection
Matt Joiner [Mon, 21 Mar 2016 03:19:51 +0000 (14:19 +1100)]
Make peerGotPiece a method on connection

8 years agoMove peerGotPiece
Matt Joiner [Mon, 21 Mar 2016 03:17:15 +0000 (14:17 +1100)]
Move peerGotPiece

8 years agoAdd some File method comments
Matt Joiner [Sat, 19 Mar 2016 06:40:30 +0000 (17:40 +1100)]
Add some File method comments

8 years agoFavour earlier pieces slightly, helps with in-order downloads
Matt Joiner [Sat, 19 Mar 2016 06:40:18 +0000 (17:40 +1100)]
Favour earlier pieces slightly, helps with in-order downloads

8 years agoFix locks on Reader.SetReadahead
Matt Joiner [Sat, 19 Mar 2016 06:39:56 +0000 (17:39 +1100)]
Fix locks on Reader.SetReadahead

8 years agoUse new missinggo.SplitHostMaybePort implementation
Matt Joiner [Tue, 15 Mar 2016 10:32:47 +0000 (21:32 +1100)]
Use new missinggo.SplitHostMaybePort implementation

8 years agoTrack accepted connections
Matt Joiner [Sun, 6 Mar 2016 06:26:04 +0000 (17:26 +1100)]
Track accepted connections

8 years agoUse missinggo.Event to track Client closed
Matt Joiner [Sat, 5 Mar 2016 08:36:21 +0000 (19:36 +1100)]
Use missinggo.Event to track Client closed

8 years agoFix a UTP Conn leak, on unencrypted followup dial attempts
Matt Joiner [Wed, 2 Mar 2016 12:27:46 +0000 (23:27 +1100)]
Fix a UTP Conn leak, on unencrypted followup dial attempts

I would guess that TCP ones were cleaned up by GC.

8 years agoAdd Reader.Torrent()
Matt Joiner [Wed, 2 Mar 2016 12:26:46 +0000 (23:26 +1100)]
Add Reader.Torrent()

8 years agoExtend the timeout, drone.io is slow?
Matt Joiner [Fri, 26 Feb 2016 11:18:08 +0000 (22:18 +1100)]
Extend the timeout, drone.io is slow?

8 years agoIgnore the corner case when a piece is dropped from storage
Matt Joiner [Fri, 26 Feb 2016 11:12:13 +0000 (22:12 +1100)]
Ignore the corner case when a piece is dropped from storage

8 years agodht: Use missinggo.Event for closing
Matt Joiner [Fri, 26 Feb 2016 11:11:48 +0000 (22:11 +1100)]
dht: Use missinggo.Event for closing

8 years agoAdd test checking that cancel works
Matt Joiner [Fri, 26 Feb 2016 11:10:29 +0000 (22:10 +1100)]
Add test checking that cancel works

8 years agoCatch error creating client in tests
Matt Joiner [Fri, 26 Feb 2016 11:10:09 +0000 (22:10 +1100)]
Catch error creating client in tests

8 years agoFix bad DHT node in tests in constructed torrent
Matt Joiner [Wed, 24 Feb 2016 10:57:30 +0000 (21:57 +1100)]
Fix bad DHT node in tests in constructed torrent

8 years agoAdd DHT nodes from metainfo when added to Client
Matt Joiner [Wed, 24 Feb 2016 10:56:50 +0000 (21:56 +1100)]
Add DHT nodes from metainfo when added to Client

8 years agodht: Rename newDHTAddr->NewAddr, and clean up the interface
Matt Joiner [Tue, 23 Feb 2016 15:02:33 +0000 (02:02 +1100)]
dht: Rename newDHTAddr->NewAddr, and clean up the interface

8 years agodht: Rename dHTAddr to Addr
Matt Joiner [Tue, 23 Feb 2016 14:50:15 +0000 (01:50 +1100)]
dht: Rename dHTAddr to Addr

8 years agoTest that metainfo nodes are added to the DHT
Matt Joiner [Tue, 23 Feb 2016 14:48:44 +0000 (01:48 +1100)]
Test that metainfo nodes are added to the DHT

8 years agometainfo: Check for error unmarshalling bad nodes contents from a metainfo
Matt Joiner [Tue, 23 Feb 2016 12:53:39 +0000 (23:53 +1100)]
metainfo: Check for error unmarshalling bad nodes contents from a metainfo

8 years agodht: Misc trivial improvements
Matt Joiner [Tue, 23 Feb 2016 12:52:30 +0000 (23:52 +1100)]
dht: Misc trivial improvements

8 years agometainfo: Fix use of CastSlice when copying nodes
Matt Joiner [Tue, 23 Feb 2016 11:47:41 +0000 (22:47 +1100)]
metainfo: Fix use of CastSlice when copying nodes

8 years agometainfo: Ensure that nodes encode correctly
Matt Joiner [Tue, 23 Feb 2016 11:37:38 +0000 (22:37 +1100)]
metainfo: Ensure that nodes encode correctly

8 years agometainfo: Support nodes as []string or [](string, int64)
Matt Joiner [Tue, 23 Feb 2016 11:28:23 +0000 (22:28 +1100)]
metainfo: Support nodes as []string or [](string, int64)

Fixes #65.

8 years agometainfo: It looks like the "nodes" field of metainfo was never handled correctly...
Matt Joiner [Tue, 23 Feb 2016 11:04:06 +0000 (22:04 +1100)]
metainfo: It looks like the "nodes" field of metainfo was never handled correctly, support []string instead of [][]string, fix tests

8 years agometainfo tests: Fix some naming conventions
Matt Joiner [Tue, 23 Feb 2016 10:50:07 +0000 (21:50 +1100)]
metainfo tests: Fix some naming conventions

8 years agobencode: Update some test code
Matt Joiner [Tue, 23 Feb 2016 10:47:00 +0000 (21:47 +1100)]
bencode: Update some test code

8 years agobencode tests: Idiomatize identifier naming
Matt Joiner [Tue, 23 Feb 2016 10:43:05 +0000 (21:43 +1100)]
bencode tests: Idiomatize identifier naming

8 years agobencode: Use the testdata convention in tests
Matt Joiner [Tue, 23 Feb 2016 10:31:15 +0000 (21:31 +1100)]
bencode: Use the testdata convention in tests

8 years agoCatch error creating new client in test
Matt Joiner [Mon, 22 Feb 2016 03:30:02 +0000 (14:30 +1100)]
Catch error creating new client in test

8 years agoFix failure to request data from peers if it goes missing after being downloaded...
Matt Joiner [Sun, 21 Feb 2016 16:23:49 +0000 (03:23 +1100)]
Fix failure to request data from peers if it goes missing after being downloaded during the same session

The chunks remained marked dirty, even after the piece was marked complete. So when the piece was not complete, there was nothing to do.

8 years agofs: Fix what looks like a glaring mistake: If Seek failed on the torrent reader,...
Matt Joiner [Sun, 21 Feb 2016 15:44:29 +0000 (02:44 +1100)]
fs: Fix what looks like a glaring mistake: If Seek failed on the torrent reader, it would have got stuck

Since Seek is artificial, and the offsets are usually checked in the caller, it looks like it never failed anyway.

8 years agoFix races in Reader
Matt Joiner [Sun, 21 Feb 2016 15:42:01 +0000 (02:42 +1100)]
Fix races in Reader

8 years agoAdd a client transfer test with limited file cache, and a second pass read
Matt Joiner [Sun, 21 Feb 2016 15:41:07 +0000 (02:41 +1100)]
Add a client transfer test with limited file cache, and a second pass read

8 years agofs: Change listen addrs to localhost in tests
Matt Joiner [Sun, 21 Feb 2016 15:39:49 +0000 (02:39 +1100)]
fs: Change listen addrs to localhost in tests

Seems to improve reliability. Maybe the missinggo.Addr{IP,Port} change did something.

8 years agofs: Tidy up tests
Matt Joiner [Sun, 21 Feb 2016 15:38:52 +0000 (02:38 +1100)]
fs: Tidy up tests

8 years agoMove exportClientStatus to testutil.ExportStatusWriter
Matt Joiner [Sun, 21 Feb 2016 15:36:41 +0000 (02:36 +1100)]
Move exportClientStatus to testutil.ExportStatusWriter

8 years agoUpdate Reader pos between reads
Matt Joiner [Sun, 21 Feb 2016 13:32:02 +0000 (00:32 +1100)]
Update Reader pos between reads

8 years agoDon't run TestCompletedPieceWrongSize in parallel because it messes up logs
Matt Joiner [Sun, 21 Feb 2016 13:31:06 +0000 (00:31 +1100)]
Don't run TestCompletedPieceWrongSize in parallel because it messes up logs

8 years agoTest a ton of permutations for readahead and responsive
Matt Joiner [Sun, 21 Feb 2016 13:30:42 +0000 (00:30 +1100)]
Test a ton of permutations for readahead and responsive

8 years agoTidy up TestClientTransfer
Matt Joiner [Sun, 21 Feb 2016 11:08:01 +0000 (22:08 +1100)]
Tidy up TestClientTransfer

8 years agoOff by one error in torrent.pieceLength?
Matt Joiner [Sun, 21 Feb 2016 06:25:47 +0000 (17:25 +1100)]
Off by one error in torrent.pieceLength?

8 years agoAdd peer_protocol.Integer.Int()
Matt Joiner [Sun, 21 Feb 2016 06:25:26 +0000 (17:25 +1100)]
Add peer_protocol.Integer.Int()

8 years agoRefresh all piece completion states when data is missing
Matt Joiner [Sun, 21 Feb 2016 06:24:59 +0000 (17:24 +1100)]
Refresh all piece completion states when data is missing

8 years agoChoke peers when we lose pieces they requested, and drop them if they request pieces...
Matt Joiner [Sun, 21 Feb 2016 06:22:55 +0000 (17:22 +1100)]
Choke peers when we lose pieces they requested, and drop them if they request pieces we don't have

8 years agoFix race updating piece priority when piece being read is unexpectedly unavailable
Matt Joiner [Sat, 20 Feb 2016 16:33:39 +0000 (03:33 +1100)]
Fix race updating piece priority when piece being read is unexpectedly unavailable

8 years agoMove dataReadAt to torrent.readAt, and do the waitNoPendingWrites check there
Matt Joiner [Sat, 20 Feb 2016 16:32:59 +0000 (03:32 +1100)]
Move dataReadAt to torrent.readAt, and do the waitNoPendingWrites check there

8 years agoDitch the torrent stateMu for the client mutex
Matt Joiner [Sat, 20 Feb 2016 16:31:50 +0000 (03:31 +1100)]
Ditch the torrent stateMu for the client mutex

8 years agoCode comment
Matt Joiner [Sat, 20 Feb 2016 03:41:04 +0000 (14:41 +1100)]
Code comment

8 years agoImprove log message
Matt Joiner [Sat, 20 Feb 2016 03:40:55 +0000 (14:40 +1100)]
Improve log message

8 years agoUse new error handling philosophy
Matt Joiner [Sat, 20 Feb 2016 03:40:28 +0000 (14:40 +1100)]
Use new error handling philosophy

8 years agoExport torrent.String to Torrent
Matt Joiner [Sat, 20 Feb 2016 03:39:56 +0000 (14:39 +1100)]
Export torrent.String to Torrent

8 years agoDitch Data.WriteSectionTo, and fix cmd/torrent-verify
Matt Joiner [Thu, 18 Feb 2016 00:45:31 +0000 (11:45 +1100)]
Ditch Data.WriteSectionTo, and fix cmd/torrent-verify

8 years agoRework Reader reading, and TestCompletedPieceWrongSize
Matt Joiner [Wed, 17 Feb 2016 07:26:10 +0000 (18:26 +1100)]
Rework Reader reading, and TestCompletedPieceWrongSize

8 years agodata/file: Return EOF on reads past end
Matt Joiner [Wed, 17 Feb 2016 06:58:20 +0000 (17:58 +1100)]
data/file: Return EOF on reads past end

8 years agoAvoid error message when we attempt to complete a piece that's already complete
Matt Joiner [Wed, 17 Feb 2016 06:21:03 +0000 (17:21 +1100)]
Avoid error message when we attempt to complete a piece that's already complete

8 years agoRemove pointless code
Matt Joiner [Wed, 17 Feb 2016 06:20:43 +0000 (17:20 +1100)]
Remove pointless code

8 years agoEnsure piece completion state is correct at startup
Matt Joiner [Wed, 17 Feb 2016 06:20:21 +0000 (17:20 +1100)]
Ensure piece completion state is correct at startup

8 years agodata/pieceStore: Incorrectly public PieceCompleted method
Matt Joiner [Wed, 17 Feb 2016 06:10:34 +0000 (17:10 +1100)]
data/pieceStore: Incorrectly public PieceCompleted method

8 years agoCode comments
Matt Joiner [Wed, 17 Feb 2016 06:09:43 +0000 (17:09 +1100)]
Code comments

8 years agoAdd a test for starting a torrent where pieces are already complete
Matt Joiner [Wed, 17 Feb 2016 06:09:05 +0000 (17:09 +1100)]
Add a test for starting a torrent where pieces are already complete

8 years agoRename issue 35 testing config function to avoid confusion
Matt Joiner [Wed, 17 Feb 2016 06:08:01 +0000 (17:08 +1100)]
Rename issue 35 testing config function to avoid confusion

8 years agoAdd torrent.completedPieces bitmap
Matt Joiner [Tue, 16 Feb 2016 13:00:55 +0000 (00:00 +1100)]
Add torrent.completedPieces bitmap

Reduce load on data.PieceComplete for torrents with lots of pieces, when reader position changes. Not sure of the improvement yet.

8 years agoImprove error message when piece fails to be completed
Matt Joiner [Tue, 16 Feb 2016 12:35:19 +0000 (23:35 +1100)]
Improve error message when piece fails to be completed

Happens occasionally on some servers, can't work out why.