package torrent
import (
+ "fmt"
+ "io"
"net"
"os"
"path/filepath"
+ "sync"
"testing"
- "github.com/anacrolix/missinggo"
- "github.com/bradfitz/iter"
+ g "github.com/anacrolix/generics"
+ "github.com/anacrolix/log"
+ "github.com/anacrolix/missinggo/v2"
+ "github.com/anacrolix/missinggo/v2/bitmap"
+ qt "github.com/frankban/quicktest"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/anacrolix/torrent/storage"
)
-func r(i, b, l pp.Integer) request {
- return request{i, chunkSpec{b, l}}
+func r(i, b, l pp.Integer) Request {
+ return Request{i, ChunkSpec{b, l}}
}
-// Check the given Request is correct for various torrent offsets.
+// Check the given request is correct for various torrent offsets.
func TestTorrentRequest(t *testing.T) {
const s = 472183431 // Length of torrent.
for _, _case := range []struct {
off int64 // An offset into the torrent.
- req request // The expected Request. The zero value means !ok.
+ req Request // The expected request. The zero value means !ok.
}{
// Invalid offset.
- {-1, request{}},
+ {-1, Request{}},
{0, r(0, 0, 16384)},
// One before the end of a piece.
{1<<18 - 1, r(0, 1<<18-16384, 16384)},
// Offset beyond torrent length.
- {472 * 1 << 20, request{}},
+ {472 * 1 << 20, Request{}},
// One before the end of the torrent. Complicates the chunk length.
{s - 1, r((s-1)/(1<<18), (s-1)%(1<<18)/(16384)*(16384), 12935)},
{1, r(0, 0, 16384)},
{16384, r(0, 16384, 16384)},
} {
req, ok := torrentOffsetRequest(472183431, 1<<18, 16384, _case.off)
- if (_case.req == request{}) == ok {
+ if (_case.req == Request{}) == ok {
t.Fatalf("expected %v, got %v", _case.req, req)
}
if req != _case.req {
numPieces = 13410
pieceLength = 256 << 10
)
- cl := &Client{}
+ cl := &Client{config: TestingConfig(b)}
+ cl.initLogger()
t := cl.newTorrent(metainfo.Hash{}, nil)
require.NoError(b, t.setInfo(&metainfo.Info{
Pieces: make([]byte, metainfo.HashSize*numPieces),
PieceLength: pieceLength,
Length: pieceLength * numPieces,
}))
+ t.onSetInfo()
assert.EqualValues(b, 13410, t.numPieces())
- for range iter.N(7) {
+ for i := 0; i < 7; i += 1 {
r := t.NewReader()
r.SetReadahead(32 << 20)
- r.Seek(3500000, 0)
+ r.Seek(3500000, io.SeekStart)
}
assert.Len(b, t.readers, 7)
for i := 0; i < t.numPieces(); i += 3 {
- t.completedPieces.Set(i, true)
+ t._completedPieces.Add(bitmap.BitIndex(i))
}
t.DownloadPieces(0, t.numPieces())
- for range iter.N(b.N) {
- t.updateAllPiecePriorities()
+ for i := 0; i < b.N; i += 1 {
+ t.updateAllPiecePriorities("")
}
}
// Check that a torrent containing zero-length file(s) will start, and that
// they're created in the filesystem. The client storage is assumed to be
// file-based on the native filesystem based.
-func testEmptyFilesAndZeroPieceLength(t *testing.T, cfg *Config) {
+func testEmptyFilesAndZeroPieceLength(t *testing.T, cfg *ClientConfig) {
cl, err := NewClient(cfg)
require.NoError(t, err)
defer cl.Close()
defer tt.Drop()
tt.DownloadAll()
require.True(t, cl.WaitAll())
+ assert.True(t, tt.Complete.Bool())
assert.True(t, missinggo.FilePathExists(fp))
}
func TestEmptyFilesAndZeroPieceLengthWithFileStorage(t *testing.T) {
- cfg := TestingConfig()
+ cfg := TestingConfig(t)
ci := storage.NewFile(cfg.DataDir)
defer ci.Close()
cfg.DefaultStorage = ci
testEmptyFilesAndZeroPieceLength(t, cfg)
}
-func TestEmptyFilesAndZeroPieceLengthWithMMapStorage(t *testing.T) {
- cfg := TestingConfig()
- ci := storage.NewMMap(cfg.DataDir)
- defer ci.Close()
- cfg.DefaultStorage = ci
- testEmptyFilesAndZeroPieceLength(t, cfg)
-}
-
func TestPieceHashFailed(t *testing.T) {
mi := testutil.GreetingMetaInfo()
- cl := new(Client)
+ cl := newTestingClient(t)
tt := cl.newTorrent(mi.HashInfoBytes(), badStorage{})
tt.setChunkSize(2)
- require.NoError(t, tt.setInfoBytes(mi.InfoBytes))
- tt.cl.mu.Lock()
- tt.pieces[1].dirtyChunks.AddRange(0, 3)
+ require.NoError(t, tt.setInfoBytesLocked(mi.InfoBytes))
+ tt.cl.lock()
+ tt.dirtyChunks.AddRange(
+ uint64(tt.pieceRequestIndexOffset(1)),
+ uint64(tt.pieceRequestIndexOffset(1)+3))
require.True(t, tt.pieceAllDirty(1))
- tt.pieceHashed(1, false)
+ tt.pieceHashed(1, false, nil)
// Dirty chunks should be cleared so we can try again.
require.False(t, tt.pieceAllDirty(1))
- tt.cl.mu.Unlock()
+ tt.cl.unlock()
}
// Check the behaviour of Torrent.Metainfo when metadata is not completed.
func TestTorrentMetainfoIncompleteMetadata(t *testing.T) {
- cfg := TestingConfig()
+ cfg := TestingConfig(t)
cfg.Debug = true
+ // Disable this just because we manually initiate a connection without it.
+ cfg.MinPeerExtensions.SetBit(pp.ExtensionBitFast, false)
cl, err := NewClient(cfg)
require.NoError(t, err)
defer cl.Close()
assert.Nil(t, tt.Metainfo().InfoBytes)
assert.False(t, tt.haveAllMetadataPieces())
- nc, err := net.Dial("tcp", cl.ListenAddr().String())
+ nc, err := net.Dial("tcp", fmt.Sprintf(":%d", cl.LocalPort()))
require.NoError(t, err)
defer nc.Close()
- var pex peerExtensionBytes
- pex.SetBit(ExtensionBitExtended)
- hr, ok, err := handshake(nc, &ih, [20]byte{}, pex)
+ var pex PeerExtensionBits
+ pex.SetBit(pp.ExtensionBitLtep, true)
+ hr, err := pp.Handshake(nc, &ih, [20]byte{}, pex)
require.NoError(t, err)
- assert.True(t, ok)
- assert.True(t, hr.peerExtensionBytes.GetBit(ExtensionBitExtended))
+ assert.True(t, hr.PeerExtensionBits.GetBit(pp.ExtensionBitLtep))
assert.EqualValues(t, cl.PeerID(), hr.PeerID)
- assert.Equal(t, ih, hr.Hash)
+ assert.EqualValues(t, ih, hr.Hash)
assert.EqualValues(t, 0, tt.metadataSize())
func() {
- cl.mu.Lock()
- defer cl.mu.Unlock()
+ cl.lock()
+ defer cl.unlock()
go func() {
_, err = nc.Write(pp.Message{
Type: pp.Extended,
assert.False(t, tt.haveAllMetadataPieces())
assert.Nil(t, tt.Metainfo().InfoBytes)
}
+
+func TestRelativeAvailabilityHaveNone(t *testing.T) {
+ c := qt.New(t)
+ var err error
+ cl := Client{
+ config: TestingConfig(t),
+ }
+ tt := Torrent{
+ cl: &cl,
+ logger: log.Default,
+ gotMetainfoC: make(chan struct{}),
+ }
+ tt.setChunkSize(2)
+ g.MakeMapIfNil(&tt.conns)
+ pc := PeerConn{}
+ pc.t = &tt
+ pc.peerImpl = &pc
+ pc.initRequestState()
+ g.InitNew(&pc.callbacks)
+ tt.conns[&pc] = struct{}{}
+ err = pc.peerSentHave(0)
+ c.Assert(err, qt.IsNil)
+ info := testutil.Greeting.Info(5)
+ err = tt.setInfo(&info)
+ c.Assert(err, qt.IsNil)
+ tt.onSetInfo()
+ err = pc.peerSentHaveNone()
+ c.Assert(err, qt.IsNil)
+ var wg sync.WaitGroup
+ tt.close(&wg)
+ tt.assertAllPiecesRelativeAvailabilityZero()
+}