admin: use a generic variable name

[public-inbox.git] / lib / PublicInbox / Admin.pm

diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index 62ddbe82e707e9a5ff8b1a83d999654b30790992..8a9a81c91180bd0f315a5440df7ba01df1adfe4c 100644 (file)
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -5,14 +5,28 @@
 # Unstable internal API
 package PublicInbox::Admin;
 use strict;
-use warnings;
-use Cwd 'abs_path';
-use base qw(Exporter);
-our @EXPORT_OK = qw(resolve_repo_dir);
+use parent qw(Exporter);
+use Cwd qw(abs_path);
+use POSIX ();
+our @EXPORT_OK = qw(resolve_repo_dir setup_signals);
 use PublicInbox::Config;
 use PublicInbox::Inbox;
 use PublicInbox::Spawn qw(popen_rd);
 
+sub setup_signals {
+       my ($cb, $arg) = @_; # optional
+
+       # we call exit() here instead of _exit() so DESTROY methods
+       # get called (e.g. File::Temp::Dir and PublicInbox::Msgmap)
+       $SIG{INT} = $SIG{HUP} = $SIG{PIPE} = $SIG{TERM} = sub {
+               my ($sig) = @_;
+               # https://www.tldp.org/LDP/abs/html/exitcodes.html
+               eval { $cb->($sig, $arg) } if $cb;
+               $sig = 'SIG'.$sig;
+               exit(128 + POSIX->$sig);
+       };
+}
+
 sub resolve_repo_dir {
        my ($cd, $ver) = @_;
        my $prefix = defined $cd ? $cd : './';
@@ -122,7 +136,7 @@ EOF
 }
 
 # TODO: make Devel::Peek optional, only used for daemon
-my @base_mod = qw(Email::MIME Devel::Peek);
+my @base_mod = qw(Devel::Peek);
 my @over_mod = qw(DBD::SQLite DBI);
 my %mod_groups = (
        -index => [ @base_mod, @over_mod ],
@@ -185,15 +199,21 @@ invalid indexlevel=$indexlevel (must be `basic', `medium', or `full')
        die missing_mod_msg($err) ." required for indexlevel=$indexlevel\n";
 }
 
+sub index_terminate {
+       my (undef, $ibx) = @_; # $_[0] = signal name
+       $ibx->git->cleanup;
+}
+
 sub index_inbox {
        my ($ibx, $im, $opt) = @_;
        my $jobs = delete $opt->{jobs} if $opt;
+       local %SIG = %SIG;
+       setup_signals(\&index_terminate, $ibx);
        if (ref($ibx) && $ibx->version == 2) {
                eval { require PublicInbox::V2Writable };
                die "v2 requirements not met: $@\n" if $@;
-               my $v2w = $im // eval { $ibx->importer(0) } || eval {
-                       PublicInbox::V2Writable->new($ibx, {nproc=>$jobs});
-               };
+               $ibx->{-creat_opt}->{nproc} = $jobs;
+               my $v2w = $im // $ibx->importer($opt->{reindex} // $jobs);
                if (defined $jobs) {
                        if ($jobs == 0) {
                                $v2w->{parallel} = 0;
@@ -236,12 +256,12 @@ sub progress_prepare ($) {
 
 # same unit factors as git:
 sub parse_unsigned ($) {
-       my ($max_size) = @_;
+       my ($val) = @_;
 
-       $$max_size =~ /\A([0-9]+)([kmg])?\z/i or return;
+       $$val =~ /\A([0-9]+)([kmg])?\z/i or return;
        my ($n, $unit_factor) = ($1, $2 // '');
        my %u = ( k => 1024, m => 1024**2, g => 1024**3 );
-       $$max_size = $n * ($u{lc($unit_factor)} // 1);
+       $$val = $n * ($u{lc($unit_factor)} // 1);
        1;
 }