No ext_urls

[public-inbox.git] / lib / PublicInbox / ExtSearch.pm

diff --git a/lib/PublicInbox/ExtSearch.pm b/lib/PublicInbox/ExtSearch.pm
index 7ce950bc11a6cfa59f9b46ecec774c6fa425872d..fa49a1d0182f75d53e4408d26fdc4f2997f6ef6e 100644 (file)
--- a/lib/PublicInbox/ExtSearch.pm
+++ b/lib/PublicInbox/ExtSearch.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2020 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
 # Read-only external (detached) index for cross inbox search.
@@ -9,7 +9,6 @@ use strict;
 use v5.10.1;
 use PublicInbox::Over;
 use PublicInbox::Inbox;
-use File::Spec ();
 use PublicInbox::MiscSearch;
 use DBI qw(:sql_types); # SQL_BLOB
 
@@ -18,9 +17,9 @@ use parent qw(PublicInbox::Search);
 
 sub new {
        my ($class, $topdir) = @_;
-       $topdir = File::Spec->canonpath($topdir);
        bless {
                topdir => $topdir,
+               -primary_address => 'unknown@example.com',
                # xpfx => 'ei15'
                xpfx => "$topdir/ei".PublicInbox::Search::SCHEMA_VERSION
        }, $class;
@@ -31,17 +30,21 @@ sub misc {
        $self->{misc} //= PublicInbox::MiscSearch->new("$self->{xpfx}/misc");
 }
 
-sub search { $_[0] } # self
-
 # same as per-inbox ->over, for now...
 sub over {
        my ($self) = @_;
-       $self->{over} //= PublicInbox::Over->new("$self->{xpfx}/over.sqlite3");
+       $self->{over} //= do {
+               PublicInbox::Inbox::_cleanup_later($self);
+               PublicInbox::Over->new("$self->{xpfx}/over.sqlite3");
+       };
 }
 
 sub git {
        my ($self) = @_;
-       $self->{git} //= PublicInbox::Git->new("$self->{topdir}/ALL.git");
+       $self->{git} //= do {
+               PublicInbox::Inbox::_cleanup_later($self);
+               PublicInbox::Git->new("$self->{topdir}/ALL.git");
+       };
 }
 
 # returns a hashref of { $NEWSGROUP_NAME => $ART_NO } using the `xref3' table
@@ -61,7 +64,7 @@ SELECT ibx_id FROM inboxes WHERE eidx_key = ? LIMIT 1
        $sth = $dbh->prepare_cached(<<'', undef, 1);
 SELECT docid FROM xref3 WHERE oidbin = ? AND xnum = ? AND ibx_id = ? LIMIT 1
 
-       $sth->bind_param(1, pack('H*', $xsmsg->{blob}), SQL_BLOB);
+       $sth->bind_param(1, $xsmsg->oidbin, SQL_BLOB);
 
        # NNTP::cmd_over can set {num} to zero according to RFC 3977 8.3.2
        $sth->bind_param(2, $xsmsg->{num} || $xsmsg->{-orig_num});
@@ -105,23 +108,25 @@ sub altid_map { {} }
 sub description {
        my ($self) = @_;
        ($self->{description} //=
-               PublicInbox::Inbox::cat_desc("$self->{topdir}/description")) //
+               PublicInbox::Git::cat_desc("$self->{topdir}/description")) //
                '$EXTINDEX_DIR/description missing';
 }
 
-sub cloneurl { [] } # TODO
+sub search {
+       PublicInbox::Inbox::_cleanup_later($_[0]);
+       $_[0];
+}
 
-sub base_url { 'https://example.com/TODO/' }
-sub nntp_url { [] }
+sub thing_type { 'external index' }
 
 no warnings 'once';
+*base_url = \&PublicInbox::Inbox::base_url;
 *smsg_eml = \&PublicInbox::Inbox::smsg_eml;
 *smsg_by_mid = \&PublicInbox::Inbox::smsg_by_mid;
 *msg_by_mid = \&PublicInbox::Inbox::msg_by_mid;
 *modified = \&PublicInbox::Inbox::modified;
-*recent = \&PublicInbox::Inbox::recent;
 
 *max_git_epoch = *nntp_usable = *msg_by_path = \&mm; # undef
-*isrch = *search;
+*isrch = \&search;
 
 1;