feed: drop needless version check

[public-inbox.git] / lib / PublicInbox / Feed.pm

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index da230525da2e42cf2b919104ad900e754b5d32e6..4cb295e60e4291f37b23137d78eaa688aacccb97 100644 (file)
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2013-2019 all contributors <meta@public-inbox.org>
+# Copyright (C) 2013-2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 #
 # Used for generating Atom feeds for web-accessible mailing list archives.
@@ -8,37 +8,28 @@ use warnings;
 use PublicInbox::MIME;
 use PublicInbox::View;
 use PublicInbox::WwwAtomStream;
-use PublicInbox::SearchMsg; # this loads w/o Search::Xapian
+use PublicInbox::Smsg; # this loads w/o Search::Xapian
+
+sub generate_i {
+       my ($ctx) = @_;
+       while (my $smsg = shift @{$ctx->{msgs}}) {
+               $ctx->{-inbox}->smsg_mime($smsg) and return $smsg;
+       }
+}
 
 # main function
 sub generate {
        my ($ctx) = @_;
-       my $msgs = recent_msgs($ctx);
+       my $msgs = $ctx->{msgs} = recent_msgs($ctx);
        return _no_thread() unless @$msgs;
-
-       my $ibx = $ctx->{-inbox};
-       PublicInbox::WwwAtomStream->response($ctx, 200, sub {
-               while (my $smsg = shift @$msgs) {
-                       $ibx->smsg_mime($smsg) and return $smsg;
-               }
-       });
+       PublicInbox::WwwAtomStream->response($ctx, 200, \&generate_i);
 }
 
 sub generate_thread_atom {
        my ($ctx) = @_;
-       my $mid = $ctx->{mid};
-       my $ibx = $ctx->{-inbox};
-       my $msgs = $ibx->over->get_thread($mid);
+       my $msgs = $ctx->{msgs} = $ctx->{-inbox}->over->get_thread($ctx->{mid});
        return _no_thread() unless @$msgs;
-
-       my $html_url = $ibx->base_url($ctx->{env});
-       $html_url .= PublicInbox::Hval->new_msgid($mid)->{href};
-       $ctx->{-html_url} = $html_url;
-       PublicInbox::WwwAtomStream->response($ctx, 200, sub {
-               while (my $smsg = shift @$msgs) {
-                       $ibx->smsg_mime($smsg) and return $smsg;
-               }
-       });
+       PublicInbox::WwwAtomStream->response($ctx, 200, \&generate_i);
 }
 
 sub generate_html_index {
@@ -59,9 +50,20 @@ sub generate_html_index {
                [ "Redirecting to $url\n" ] ];
 }
 
+sub new_html_i {
+       my ($nr, $ctx) = @_;
+       my $msgs = $ctx->{msgs};
+       while (my $smsg = shift @$msgs) {
+               my $m = $ctx->{-inbox}->smsg_mime($smsg) or next;
+               my $more = scalar @$msgs;
+               return PublicInbox::View::index_entry($m, $ctx, $more);
+       }
+       PublicInbox::View::pagination_footer($ctx, './new.html');
+}
+
 sub new_html {
        my ($ctx) = @_;
-       my $msgs = recent_msgs($ctx);
+       my $msgs = $ctx->{msgs} = recent_msgs($ctx);
        if (!@$msgs) {
                return [404, ['Content-Type', 'text/plain'],
                        ["No messages, yet\n"] ];
@@ -69,15 +71,7 @@ sub new_html {
        $ctx->{-html_tip} = '<pre>';
        $ctx->{-upfx} = '';
        $ctx->{-hr} = 1;
-       my $ibx = $ctx->{-inbox};
-       PublicInbox::WwwStream->response($ctx, 200, sub {
-               while (my $smsg = shift @$msgs) {
-                       my $m = $ibx->smsg_mime($smsg) or next;
-                       my $more = scalar @$msgs;
-                       return PublicInbox::View::index_entry($m, $ctx, $more);
-               }
-               PublicInbox::View::pagination_footer($ctx, './new.html');
-       });
+       PublicInbox::WwwStream->response($ctx, 200, \&new_html_i);
 }
 
 # private subs
@@ -90,15 +84,10 @@ sub recent_msgs {
        my ($ctx) = @_;
        my $ibx = $ctx->{-inbox};
        my $max = $ibx->{feedmax};
-       my $qp = $ctx->{qp};
-       my $v = $ibx->{version} || 1;
-       if ($v > 2) {
-               die "BUG: unsupported inbox version: $v\n";
-       }
-       if ($ibx->over) {
-               return PublicInbox::View::paginate_recent($ctx, $max);
-       }
+       return PublicInbox::View::paginate_recent($ctx, $max) if $ibx->over;
 
+       # only for rare v1 inboxes which aren't indexed at all
+       my $qp = $ctx->{qp};
        my $hex = '[a-f0-9]';
        my $addmsg = qr!^:000000 100644 \S+ (\S+) A\t${hex}{2}/${hex}{38}$!;
        my $delmsg = qr!^:100644 000000 (\S+) \S+ D\t(${hex}{2}/${hex}{38})$!;
@@ -148,7 +137,7 @@ sub recent_msgs {
        }
 
        $ctx->{next_page} = "r=$last_commit" if $last_commit;
-       [ map { bless {blob => $_ }, 'PublicInbox::SearchMsg' } @oids ];
+       [ map { bless {blob => $_ }, 'PublicInbox::Smsg' } @oids ];
 }
 
 1;