add various TODO items

[public-inbox.git] / lib / PublicInbox / Feed.pm

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index a507cda12350a7fda8bbd67a7b727b45f0f36638..6996f374e555a4f55d565fda80fe3b119369e3b0 100644 (file)
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -9,8 +9,8 @@ use Date::Parse qw(strptime str2time);
 use PublicInbox::Hval;
 use PublicInbox::GitCatFile;
 use constant {
-       DATEFMT => '%Y-%m-%dT%H:%M:%SZ',
-       MAX_PER_PAGE => 25,
+       DATEFMT => '%Y-%m-%dT%H:%M:%SZ', # atom standard
+       MAX_PER_PAGE => 25, # this needs to be tunable
 };
 
 # main function
@@ -243,7 +243,7 @@ sub add_to_feed {
        defined $mid or return 0;
        $mid = PublicInbox::Hval->new_msgid($mid);
        my $href = $mid->as_href . '.html';
-       my $content = PublicInbox::View->as_feed_entry($mime, $fullurl . $href);
+       my $content = PublicInbox::View->feed_entry($mime, $fullurl . $href);
        defined($content) or return 0;
 
        my $subject = mime_header($mime, 'Subject') or return 0;
@@ -299,7 +299,7 @@ sub dump_html_line {
 sub do_cat_mail {
        my ($git, $path) = @_;
        my $str = $git->cat_file("HEAD:$path");
-       Email::MIME->new($$str);
+       Email::MIME->new($str);
 }
 
 1;