git_async_cat: fix outdated comment

[public-inbox.git] / lib / PublicInbox / GitAsyncCat.pm

diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index 65e161219699e45730e637be17bde7b94a7e9166..5f785df72ae4fb387a3ddb8aa28464adc4d65bbb 100644 (file)
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -1,7 +1,7 @@
 # Copyright (C) 2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 #
-# internal class used by PublicInbox::Git + Danga::Socket
+# internal class used by PublicInbox::Git + PublicInbox::DS
 # This parses the output pipe of "git cat-file --batch"
 #
 # Note: this does NOT set the non-blocking flag, we expect `git cat-file'
@@ -11,39 +11,32 @@
 package PublicInbox::GitAsyncCat;
 use strict;
 use parent qw(PublicInbox::DS Exporter);
-use fields qw(git);
 use PublicInbox::Syscall qw(EPOLLIN EPOLLET);
-our @EXPORT = qw(git_async_msg);
+our @EXPORT = qw(git_async_cat);
 
-sub new {
+sub _add {
        my ($class, $git) = @_;
-       my $self = fields::new($class);
        $git->batch_prepare;
+       my $self = bless { git => $git }, $class;
        $self->SUPER::new($git->{in}, EPOLLIN|EPOLLET);
-       $self->{git} = $git;
-       $self;
+       \undef; # this is a true ref()
 }
 
 sub event_step {
        my ($self) = @_;
-       my $git = $self->{git} or return; # ->close-ed
+       my $git = $self->{git};
+       return $self->close if ($git->{in} // 0) != ($self->{sock} // 1);
        my $inflight = $git->{inflight};
-       if (@$inflight) {
+       if ($inflight && @$inflight) {
                $git->cat_async_step($inflight);
                $self->requeue if @$inflight || exists $git->{cat_rbuf};
        }
 }
 
-sub close {
-       my ($self) = @_;
-       delete $self->{git};
-       $self->SUPER::close; # PublicInbox::DS::close
-}
-
-sub git_async_msg ($$$$) {
-       my ($ibx, $smsg, $cb, $arg) = @_;
-       $ibx->git->cat_async($smsg->{blob}, $cb, $arg);
-       $ibx->{async_cat} //= new(__PACKAGE__, $ibx->{git});
+sub git_async_cat ($$$$) {
+       my ($git, $oid, $cb, $arg) = @_;
+       $git->cat_async($oid, $cb, $arg);
+       $git->{async_cat} //= _add(__PACKAGE__, $git);
 }
 
 1;