gzipfilter: replace Compress::Raw::Deflate usages

[public-inbox.git] / lib / PublicInbox / GzipFilter.pm

diff --git a/lib/PublicInbox/GzipFilter.pm b/lib/PublicInbox/GzipFilter.pm
index 8cc5ea00bc09880137b623f0b59af6d953dcb2e7..d2eb4e6643e500f7a77cdf27aecb75380be8377c 100644 (file)
--- a/lib/PublicInbox/GzipFilter.pm
+++ b/lib/PublicInbox/GzipFilter.pm
@@ -6,7 +6,7 @@ package PublicInbox::GzipFilter;
 use strict;
 use parent qw(Exporter);
 use Compress::Raw::Zlib qw(Z_FINISH Z_OK);
-our @EXPORT_OK = qw(gzip_maybe gzf_maybe);
+our @EXPORT_OK = qw(gzf_maybe);
 my %OPT = (-WindowBits => 15 + 16, -AppendOutput => 1);
 my @GZIP_HDRS = qw(Vary Accept-Encoding Content-Encoding gzip);
 
@@ -19,24 +19,23 @@ sub attach {
        $self
 }
 
-sub gzip_maybe ($$) {
+# returns `0' and not `undef' on failure (see Www*Stream)
+sub gzf_maybe ($$) {
        my ($res_hdr, $env) = @_;
-       return if (($env->{HTTP_ACCEPT_ENCODING}) // '') !~ /\bgzip\b/;
-
+       return 0 if (($env->{HTTP_ACCEPT_ENCODING}) // '') !~ /\bgzip\b/;
        my ($gz, $err) = Compress::Raw::Zlib::Deflate->new(%OPT);
-       return if $err != Z_OK;
+       return 0 if $err != Z_OK;
 
        # in case Plack::Middleware::Deflater is loaded:
        $env->{'plack.skip-deflater'} = 1;
-
        push @$res_hdr, @GZIP_HDRS;
-       $gz;
+       bless { gz => $gz }, __PACKAGE__;
 }
 
-sub gzf_maybe ($$) {
-       my ($res_hdr, $env) = @_;
-       my $gz = gzip_maybe($res_hdr, $env) or return 0;
-       bless { gz => $gz }, __PACKAGE__;
+sub gzip_or_die () {
+       my ($gz, $err) = Compress::Raw::Zlib::Deflate->new(%OPT);
+       $err == Z_OK or die "Deflate->new failed: $err";
+       $gz;
 }
 
 # for GetlineBody (via Qspawn) when NOT using $env->{'pi-httpd.async'}
@@ -47,11 +46,7 @@ sub translate ($$) {
        # allocate the zlib context lazily here, instead of in ->new.
        # Deflate contexts are memory-intensive and this object may
        # be sitting in the Qspawn limiter queue for a while.
-       my $gz = $self->{gz} //= do {
-               my ($g, $err) = Compress::Raw::Zlib::Deflate->new(%OPT);
-               $err == Z_OK or die "Deflate->new failed: $err";
-               $g;
-       };
+       my $gz = $self->{gz} //= gzip_or_die();
        my $zbuf = delete($self->{zbuf});
        if (defined $_[1]) { # my $buf = $_[1];
                my $err = $gz->deflate($_[1], $zbuf);