http: chunk in the server, not middleware

[public-inbox.git] / lib / PublicInbox / HTTP.pm

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 6576bf684931e6835ef9d07b4268e265a5ed8542..77b178c07e6fea56cfe47c9b95a7358499f91088 100644 (file)
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -11,7 +11,7 @@ package PublicInbox::HTTP;
 use strict;
 use warnings;
 use base qw(Danga::Socket);
-use fields qw(httpd env rbuf input_left remote_addr remote_port);
+use fields qw(httpd env rbuf input_left remote_addr remote_port forward);
 use Fcntl qw(:seek);
 use Plack::HTTPParser qw(parse_http_request); # XS or pure Perl
 use HTTP::Status qw(status_message);
@@ -180,12 +180,19 @@ sub response_header_write {
 
        my $conn = $env->{HTTP_CONNECTION} || '';
        my $term = defined($len) || $chunked;
-       my $alive = $term &&
-                       (($proto eq 'HTTP/1.1' && $conn !~ /\bclose\b/i) ||
-                        ($conn =~ /\bkeep-alive\b/i));
-
-       $h .= 'Connection: ' . ($alive ? 'keep-alive' : 'close');
-       $h .= "\r\nDate: " . http_date() . "\r\n\r\n";
+       my $prot_persist = ($proto eq 'HTTP/1.1') && ($conn !~ /\bclose\b/i);
+       my $alive;
+       if (!$term && $prot_persist) { # auto-chunk
+               $chunked = $alive = 2;
+               $h .= "Transfer-Encoding: chunked\r\n";
+               # no need for "Connection: keep-alive" with HTTP/1.1
+       } elsif ($term && ($prot_persist || ($conn =~ /\bkeep-alive\b/i))) {
+               $alive = 1;
+               $h .= "Connection: keep-alive\r\n";
+       } else {
+               $h .= "Connection: close\r\n";
+       }
+       $h .= 'Date: ' . http_date() . "\r\n\r\n";
 
        if (($len || $chunked) && $env->{REQUEST_METHOD} ne 'HEAD') {
                more($self, $h);
@@ -195,13 +202,29 @@ sub response_header_write {
        $alive;
 }
 
+# middlewares such as Deflater may write empty strings
+sub chunked_wcb ($) {
+       my ($self) = @_;
+       sub {
+               return if $_[0] eq '';
+               more($self, sprintf("%x\r\n", bytes::length($_[0])));
+               more($self, $_[0]);
+               $self->write("\r\n");
+       }
+}
+
+sub identity_wcb ($) {
+       my ($self) = @_;
+       sub { $self->write(\($_[0])) if $_[0] ne '' }
+}
+
 sub response_write {
        my ($self, $env, $res) = @_;
        my $alive = response_header_write($self, $env, $res);
 
-       # middlewares such as Deflater may write empty strings
-       my $write = sub { $self->write($_[0]) if $_[0] ne '' };
+       my $write = $alive == 2 ? chunked_wcb($self) : identity_wcb($self);
        my $close = sub {
+               $self->write("0\r\n\r\n") if $alive == 2;
                if ($alive) {
                        $self->event_write; # watch for readability if done
                } else {
@@ -219,24 +242,6 @@ sub response_write {
                if (ref $body eq 'ARRAY') {
                        $write->($_) foreach @$body;
                        $close->();
-               } elsif ($body->can('async_pass')) { # HTTPD::Async
-                       # prevent us from reading the body faster than we
-                       # can write to the client
-                       my $restart_read = sub { $body->watch_read(1) };
-                       $body->async_pass(sub {
-                               local $/ = \8192;
-                               my $buf = $body->getline;
-                               if (defined $buf) {
-                                       $write->($buf);
-                                       if ($self->{write_buf_size}) {
-                                               $body->watch_read(0);
-                                               $self->write($restart_read);
-                                       }
-                                       return; # continue waiting
-                               }
-                               $body->close;
-                               $close->();
-                       });
                } else {
                        my $pull;
                        $pull = sub {
@@ -438,7 +443,9 @@ sub event_err { $_[0]->close }
 
 sub close {
        my $self = shift;
-       $self->{env} = undef;
+       my $forward = $self->{forward};
+       $forward->close if $forward;
+       $self->{forward} = $self->{env} = undef;
        $self->SUPER::close(@_);
 }