inbox: simplify filtering for duplicate NNTP URLs

[public-inbox.git] / lib / PublicInbox / Inbox.pm

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index ff80096528eb2301aae63c9389dba01421051868..07e8b5b754071de5c8264d9e95034469e45b1128 100644 (file)
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -52,7 +52,7 @@ sub cleanup_task () {
 sub cleanup_possible () {
        # no need to require DS, here, if it were enabled another
        # module would've require'd it, already
-       eval { $PublicInbox::DS::in_loop } or return 0;
+       eval { PublicInbox::DS::in_loop() } or return 0;
 
        eval {
                require Devel::Peek; # needs separate package in Fedora
@@ -293,12 +293,11 @@ sub nntp_url {
                                # nntp://news.example.com/alt.example
                                push @m, $u;
                        }
-                       my %seen = map { $_ => 1 } @urls;
-                       foreach my $u (@m) {
-                               next if $seen{$u};
-                               $seen{$u} = 1;
-                               push @urls, $u;
-                       }
+
+                       # List::Util::uniq requires Perl 5.26+, maybe we
+                       # can use it by 2030 or so
+                       my %seen;
+                       @urls = grep { !$seen{$_}++ } (@urls, @m);
                }
                \@urls;
        };