treewide: kill problematic "$h->{k} //= do {" assignments

[public-inbox.git] / lib / PublicInbox / Inbox.pm

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 724df50a7134725601cd1c2ce83d9a9f41805c77..1579d500136a8f814f532275f486bc117c3e0441 100644 (file)
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -4,6 +4,7 @@
 # Represents a public-inbox (which may have multiple mailing addresses)
 package PublicInbox::Inbox;
 use strict;
+use v5.10.1;
 use PublicInbox::Git;
 use PublicInbox::MID qw(mid2path);
 use PublicInbox::Eml;
@@ -11,8 +12,6 @@ use List::Util qw(max);
 use Carp qw(croak);
 
 # returns true if further checking is required
-sub cleanup_shards { $_[0]->{search} ? $_[0]->{search}->cleanup_shards : undef }
-
 sub check_inodes ($) {
        for (qw(over mm)) { $_[0]->{$_}->check_inodes if $_[0]->{$_} }
 }
@@ -31,7 +30,8 @@ sub do_cleanup {
                delete(@$ibx{qw(over mm description cloneurl
                                -imap_url -nntp_url)});
        }
-       $ibx->cleanup_shards and $live = 1;
+       my $srch = $ibx->{search} // $ibx;
+       delete @$srch{qw(xdb qp)};
        for my $git (@{$ibx->{-repo_objs} // []}) {
                $live = 1 if $git->cleanup(1);
        }
@@ -48,7 +48,7 @@ sub _cleanup_later ($) {
 sub _set_limiter ($$$) {
        my ($self, $pi_cfg, $pfx) = @_;
        my $lkey = "-${pfx}_limiter";
-       $self->{$lkey} ||= do {
+       $self->{$lkey} //= do {
                # full key is: publicinbox.$NAME.httpbackendmax
                my $mkey = $pfx.'max';
                my $val = $self->{$mkey} or return;
@@ -138,17 +138,18 @@ sub max_git_epoch {
        $cur;
 }
 
+sub mm_file {
+       my ($self) = @_;
+       my $d = $self->{inboxdir};
+       ($self->version >= 2 ? $d : "$d/public-inbox").'/msgmap.sqlite3';
+}
+
 sub mm {
        my ($self, $req) = @_;
        $self->{mm} //= eval {
                require PublicInbox::Msgmap;
                _cleanup_later($self);
-               my $dir = $self->{inboxdir};
-               if ($self->version >= 2) {
-                       PublicInbox::Msgmap->new_file("$dir/msgmap.sqlite3");
-               } else {
-                       PublicInbox::Msgmap->new($dir);
-               }
+               PublicInbox::Msgmap->new_file($self);
        } // ($req ? croak("E: $@") : undef);
 }
 
@@ -293,17 +294,15 @@ sub msg_by_smsg ($$) {
 
        # ghosts may have undef smsg (from SearchThread.node) or
        # no {blob} field
-       return unless defined $smsg;
-       defined(my $blob = $smsg->{blob}) or return;
-
-       $self->git->cat_file($blob);
+       $smsg // return;
+       $self->git->cat_file($smsg->{blob} // return);
 }
 
 sub smsg_eml {
        my ($self, $smsg) = @_;
        my $bref = msg_by_smsg($self, $smsg) or return;
        my $eml = PublicInbox::Eml->new($bref);
-       $smsg->populate($eml) unless exists($smsg->{num}); # v1 w/o SQLite
+       $smsg->{num} // $smsg->populate($eml);
        $eml;
 }
 
@@ -313,7 +312,7 @@ sub smsg_by_mid ($$) {
        my $smsg;
        if (my $mm = $self->mm) {
                # favor the Message-ID we used for the NNTP article number:
-               defined(my $num = $mm->num_for($mid)) or return;
+               my $num = $mm->num_for($mid) // return;
                $smsg = $over->get_art($num);
        } else {
                my ($id, $prev);