treewide: kill problematic "$h->{k} //= do {" assignments

[public-inbox.git] / lib / PublicInbox / Inbox.pm

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 74b8a74f8856e7992fd29b742ff89f75d1dddaf3..1579d500136a8f814f532275f486bc117c3e0441 100644 (file)
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -4,6 +4,7 @@
 # Represents a public-inbox (which may have multiple mailing addresses)
 package PublicInbox::Inbox;
 use strict;
+use v5.10.1;
 use PublicInbox::Git;
 use PublicInbox::MID qw(mid2path);
 use PublicInbox::Eml;
@@ -47,7 +48,7 @@ sub _cleanup_later ($) {
 sub _set_limiter ($$$) {
        my ($self, $pi_cfg, $pfx) = @_;
        my $lkey = "-${pfx}_limiter";
-       $self->{$lkey} ||= do {
+       $self->{$lkey} //= do {
                # full key is: publicinbox.$NAME.httpbackendmax
                my $mkey = $pfx.'max';
                my $val = $self->{$mkey} or return;
@@ -293,17 +294,15 @@ sub msg_by_smsg ($$) {
 
        # ghosts may have undef smsg (from SearchThread.node) or
        # no {blob} field
-       return unless defined $smsg;
-       defined(my $blob = $smsg->{blob}) or return;
-
-       $self->git->cat_file($blob);
+       $smsg // return;
+       $self->git->cat_file($smsg->{blob} // return);
 }
 
 sub smsg_eml {
        my ($self, $smsg) = @_;
        my $bref = msg_by_smsg($self, $smsg) or return;
        my $eml = PublicInbox::Eml->new($bref);
-       $smsg->populate($eml) unless exists($smsg->{num}); # v1 w/o SQLite
+       $smsg->{num} // $smsg->populate($eml);
        $eml;
 }
 
@@ -313,7 +312,7 @@ sub smsg_by_mid ($$) {
        my $smsg;
        if (my $mm = $self->mm) {
                # favor the Message-ID we used for the NNTP article number:
-               defined(my $num = $mm->num_for($mid)) or return;
+               my $num = $mm->num_for($mid) // return;
                $smsg = $over->get_art($num);
        } else {
                my ($id, $prev);