($lei->{opt}->{jobs} // 1) > 1;
push @cmd, '-v' if $lei->{opt}->{verbose};
# XXX any other options to support?
- # --reference is tricky with multiple epochs...
+ # --reference is tricky with multiple epochs, but handled
+ # automatically if using manifest.js.gz
@cmd;
}
open my $fh, '+>>', $f or die "open($f): $!";
seek($fh, 0, SEEK_SET) or die "seek($f): $!";
my $d = do { local $/; <$fh> } // die "read($f): $!";
- my $orig = $d;
+ chomp(my $orig = $d);
while (defined($d) && ($d =~ m!^\(\$INBOX_DIR/description missing\)! ||
$d =~ /^Unnamed repository/ || $d !~ /\S/)) {
$d = delete($self->{'txt.description'});
}
- $d //= 'mirror of '.($self->{cur_src} // $self->{src})."\n";
+ $d //= 'mirror of '.($self->{cur_src} // $self->{src});
+ chomp $d;
return if $d eq $orig;
seek($fh, 0, SEEK_SET) or die "seek($f): $!";
truncate($fh, 0) or die "truncate($f): $!";
- print $fh $d or die "print($f): $!";
+ print $fh $d, "\n" or die "print($f): $!";
close $fh or die "close($f): $!";
}
push @$cmd, '--reference', "$self->{dst}$ref";
start_clone($self, $cmd, $opt, $fini);
- $lei->{opt}->{'inbox-config'} =~ /\A(?:always|v1)\z/s and
+ if (!$self->{-is_epoch} && $lei->{opt}->{'inbox-config'} =~
+ /\A(?:always|v1)\z/s) {
_get_txt_start($self, '_/text/config/raw', $fini);
+ }
+
my $d = $self->{-ent} ? $self->{-ent}->{description} : undef;
- defined($d) ? ($self->{'txt.description'} = $d) :
+ $self->{'txt.description'} = $d if defined $d;
+ (!defined($d) && !$nohang) and
_get_txt_start($self, 'description', $fini);
reap_live() until ($nohang || !keys(%$LIVE)); # for non-manifest clone
EOM
}
close $fh or die "close($f): $!";
- if (defined $ent->{head}) {
- $f = "$edst/HEAD";
- open $fh, '>', $f or die "open($f): $!";
- print $fh $ent->{head}, "\n" or die "print($f): $!";
- close $fh or die "close($f): $!";
+ my %map = (head => 'HEAD', description => undef);
+ while (my ($key, $fn) = each %map) {
+ my $val = $ent->{$key} // next;
+ $fn //= $key;
+ $fn = "$edst/$fn";
+ open $fh, '>', $fn or die "open($fn): $!";
+ print $fh $val, "\n" or die "print($fn): $!";
+ close $fh or die "close($fn): $!";
}
}
die "rename($f, $o/info/alternates): $!";
$f->unlink_on_destroy(0);
}
+ return if $self->{-is_epoch};
write_makefile($dst, 1);
index_cloned_inbox($self, 1);
}
my ($self) = @_;
return if $self->{dry_run} || !$LIVE;
my $dst = $self->{cur_dst} // $self->{dst};
+ require PublicInbox::Lock;
my $lk = bless { lock_path => "$dst/inbox.lock" }, 'PublicInbox::Lock';
my $lck = $lk->lock_for_scope($$);
_write_inbox_config($self);
my $mg = PublicInbox::MultiGit->new($dst, 'all.git', 'git');
$mg->fill_alternates;
for my $i ($mg->git_epochs) { $mg->epoch_cfg_set($i) }
- my $edst_owner = delete($self->{-owner}) // [];
- while (@$edst_owner) {
- my ($edst, $o) = splice(@$edst_owner);
- run_die [qw(git config -f), "$edst/config", 'gitweb.owner', $o];
+ my $entries = delete($self->{-entv}) // [];
+ while (@$entries) {
+ my ($edst, $ent) = splice(@$entries);
+ if (defined(my $o = $ent->{owner})) {
+ run_die [qw(git config -f), "$edst/config",
+ 'gitweb.owner', $o];
+ }
+ my $d = $ent->{description} // next;
+ my $fn = "$edst/description";
+ open my $fh, '>', $fn or die "open($fn): $!";
+ print $fh $d, "\n" or die "print($fn): $!";
+ close $fh or die "close($fn): $!";
}
for my $edst (@{delete($self->{-read_only}) // []}) {
my @st = stat($edst) or die "stat($edst): $!";
my $dst = $self->{cur_dst} // $self->{dst};
my $want = parse_epochs($lei->{opt}->{epoch}, $v2_epochs);
my $task = $m ? bless { %$self }, __PACKAGE__ : $self;
- my (@src_edst, @skip);
+ delete $task->{todo}; # $self->{todo} still exists
+ my (@src_edst, @skip, $desc);
for my $nr (sort { $a <=> $b } keys %$v2_epochs) {
my ($uri, $key) = @{$v2_epochs->{$nr}};
my $src = $uri->as_string;
$1 + 0 == $nr or die "BUG: <$uri> miskeyed $1 != $nr";
$edst .= "/git/$nr.git";
- $m->{$key} // die "BUG: `$key' not in manifest.js.gz";
+ my $ent = $m->{$key} // die "BUG: `$key' not in manifest.js.gz";
+ if (defined(my $d = $ent->{description})) {
+ $d =~ s/ \[epoch [0-9]+\]\z//s;
+ $desc = $d;
+ }
if (!$want || $want->{$nr}) {
push @src_edst, $src, $edst;
- my $o = $m->{$key}->{owner};
- push(@{$task->{-owner}}, $edst, $o) if defined($o);
+ push @{$task->{-entv}}, $edst, $ent;
+ $self->{any_want}->{$key} = 1;
} else { # create a placeholder so users only need to chmod +w
- init_placeholder($src, $edst, $m->{$key});
+ init_placeholder($src, $edst, $ent);
push @{$task->{-read_only}}, $edst;
push @skip, $key;
}
(!$self->{dry_run} && !-d $dst) and File::Path::mkpath($dst);
- require PublicInbox::Lock;
my $fini = PublicInbox::OnDestroy->new($$, \&v2_done, $task);
$lei->{opt}->{'inbox-config'} =~ /\A(?:always|v2)\z/s and
_get_txt_start($task, '_/text/config/raw', $fini);
- _get_txt_start($task, 'description', $fini);
-
- my @cmd = clone_cmd($lei, my $opt = {});
- while (@src_edst && !$lei->{child_error}) {
- my $cmd = [ @$pfx, @cmd, splice(@src_edst, 0, 2) ];
- start_clone($self, $cmd, $opt, $fini);
+ defined($desc) ? ($task->{'txt.description'} = $desc) :
+ _get_txt_start($task, 'description', $fini);
+ if (my $todo = $self->{todo}) { # manifest clone, deal with references
+ my $entv = delete $task->{-entv};
+ while (@$entv) {
+ my ($edst, $ent) = splice(@$entv, 0, 2);
+ my $etask = bless { %$task }, __PACKAGE__;
+ $etask->{-ent} = $ent; # may have {reference}
+ $etask->{cur_src} = shift @src_edst //
+ die 'BUG: no cur_src';
+ $etask->{cur_dst} = shift @src_edst //
+ die 'BUG: no cur_dst';
+ $etask->{cur_dst} eq $edst or
+ die "BUG: `$etask->{cur_dst}' != `$edst'";
+ $etask->{-is_epoch} = $fini;
+ push @{$todo->{($ent->{reference} // '')}}, $etask;
+ }
+ } else {
+ my @cmd = clone_cmd($lei, my $opt = {});
+ while (@src_edst && !$lei->{child_error}) {
+ my $cmd = [ @$pfx, @cmd, splice(@src_edst, 0, 2) ];
+ start_clone($self, $cmd, $opt, $fini);
+ }
}
}
my $n = scalar(keys %$v2) + scalar(@v1);
my @orig = defined($incl // $excl) ? (keys %$v2, @v1) : ();
if (defined $incl) {
- my $re = '(?:'.join('|', map {
- $self->{lei}->glob2re($_) // qr/\A\Q$_\E\z/
- } @$incl).')';
+ my $re = '(?:'.join('\\z|', map {
+ $self->{lei}->glob2re($_) // qr/\A\Q$_\E/
+ } @$incl).'\\z)';
my @gone = delete @$v2{grep(!/$re/, keys %$v2)};
delete @$m{map { @$_ } @gone} and $self->{-culled_manifest} = 1;
delete @$m{grep(!/$re/, @v1)} and $self->{-culled_manifest} = 1;
@v1 = grep(/$re/, @v1);
}
if (defined $excl) {
- my $re = '(?:'.join('|', map {
- $self->{lei}->glob2re($_) // qr/\A\Q$_\E\z/
- } @$excl).')';
+ my $re = '(?:'.join('\\z|', map {
+ $self->{lei}->glob2re($_) // qr/\A\Q$_\E/
+ } @$excl).'\\z)';
my @gone = delete @$v2{grep(/$re/, keys %$v2)};
delete @$m{map { @$_ } @gone} and $self->{-culled_manifest} = 1;
delete @$m{grep(/$re/, @v1)} and $self->{-culled_manifest} = 1;
($path_pfx, $n, $ret);
}
-sub clone_all {
- my ($self, $todo, $m) = @_;
+sub clone_all ($$) {
+ my ($self, $m) = @_;
+ my $todo = delete $self->{todo};
+ my $nodep = delete $todo->{''};
+
+ # do not download unwanted deps
+ my $any_want = delete $self->{any_want};
+ my @unwanted = grep { !$any_want->{$_} } keys %$todo;
+ my @nodep = delete(@$todo{@unwanted});
+ push(@$nodep, @$_) for @nodep;
+
# handle no-dependency repos, first
- for (@{delete($todo->{''}) // []}) {
+ for (@$nodep) {
clone_v1($_, 1);
return if $self->{lei}->{child_error};
}
# resolve references, deepest, first:
while (scalar keys %$todo) {
for my $x (keys %$todo) {
+ my $nr;
# resolve multi-level references
- while (defined($m->{$x}->{reference})) {
- $x = $m->{$x}->{reference};
+ while (defined(my $nxt = $m->{$x}->{reference})) {
+ exists($todo->{$nxt}) or last;
+ die <<EOM if ++$nr > 1000;
+E: dependency loop detected (`$x' => `$nxt')
+EOM
+ $x = $nxt;
}
my $y = delete $todo->{$x} // next; # already done
for (@$y) {
}
my ($path_pfx, $n, $multi) = multi_inbox($self, \$path, $m);
return $lei->child_error(1, $multi) if !ref($multi);
- if (my $v2 = delete $multi->{v2}) {
+ my $v2 = delete $multi->{v2};
+ local $self->{todo} = {};
+ if ($v2) {
for my $name (sort keys %$v2) {
my $epochs = delete $v2->{$name};
my %v2_epochs = map {
my $p = $path_pfx.$path;
chop($p) if substr($p, -1, 1) eq '/';
$uri->path($p);
- my $todo = {};
- my %want = map { $_ => 1 } @$v1;
for my $name (@$v1) {
my $task = bless { %$self }, __PACKAGE__;
$task->{-ent} = $m->{$name} //
EOM
$task->{cur_src} .= '/';
my $dep = $task->{-ent}->{reference} // '';
- $dep = '' if !$want{$dep};
- push @{$todo->{$dep}}, $task;
+ push @{$self->{todo}->{$dep}}, $task;
+ $self->{any_want}->{$name} = 1;
}
- clone_all($self, $todo, $m);
}
+ delete local $lei->{opt}->{epoch} if defined($v2);
+ clone_all($self, $m);
reap_live() while keys(%$LIVE);
return if $self->{lei}->{child_error} || $self->{dry_run};