]> Sergey Matveev's repositories - public-inbox.git/blobdiff - lib/PublicInbox/LeiOverview.pm
lei q: do not leave temporary files after oneshot exit
[public-inbox.git] / lib / PublicInbox / LeiOverview.pm
index 880c7acccb09f7d86c5169f9195483184217a6b8..31cc67f112efee5db69c7d7abae2f0efbca91a3c 100644 (file)
@@ -26,16 +26,15 @@ sub _iso8601 ($) { strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($_[0])) }
 # we open this in the parent process before ->wq_do handoff
 sub ovv_out_lk_init ($) {
        my ($self) = @_;
-       $self->{tmp_lk_id} = "$self.$$";
        my $tmp = File::Temp->new("lei-ovv.dst.$$.lock-XXXXXX",
                                        TMPDIR => 1, UNLINK => 0);
-       $self->{lock_path} = $tmp->filename;
+       $self->{"lk_id.$self.$$"} = $self->{lock_path} = $tmp->filename;
 }
 
 sub ovv_out_lk_cancel ($) {
        my ($self) = @_;
-       ($self->{tmp_lk_id}//'') eq "$self.$$" and
-               unlink(delete($self->{lock_path}));
+       my $lock_path = delete $self->{"lk_id.$self.$$"} or return;
+       unlink($lock_path);
 }
 
 sub detect_fmt ($$) {
@@ -92,13 +91,14 @@ sub new {
                        ovv_out_lk_init($self);
                }
        }
-       if (!$json) {
+       if ($json) {
+               $lei->{dedupe} //= PublicInbox::LeiDedupe->new($lei);
+       } else {
                # default to the cheapest sort since MUA usually resorts
                $lei->{opt}->{'sort'} //= 'docid' if $dst ne '/dev/stdout';
                $lei->{l2m} = eval { PublicInbox::LeiToMail->new($lei) };
                return $lei->fail($@) if $@;
        }
-       $lei->{dedupe} //= PublicInbox::LeiDedupe->new($lei);
        $self;
 }
 
@@ -106,28 +106,22 @@ sub new {
 sub ovv_begin {
        my ($self, $lei) = @_;
        if ($self->{fmt} eq 'json') {
-               print { $lei->{1} } '[';
+               $lei->out('[');
        } # TODO HTML/Atom/...
 }
 
 # called once by parent (via PublicInbox::EOFpipe)
 sub ovv_end {
        my ($self, $lei) = @_;
-       my $out = $lei->{1} or return;
        if ($self->{fmt} eq 'json') {
                # JSON doesn't allow trailing commas, and preventing
                # trailing commas is a PITA when parallelizing outputs
-               print $out "null]\n";
+               $lei->out("null]\n");
        } elsif ($self->{fmt} eq 'concatjson') {
-               print $out "\n";
+               $lei->out("\n");
        }
 }
 
-sub ovv_atfork_child {
-       my ($self) = @_;
-       # reopen dedupe here
-}
-
 # prepares an smsg for JSON
 sub _unbless_smsg {
        my ($smsg, $mitem) = @_;
@@ -167,9 +161,8 @@ sub ovv_atexit_child {
                $git->async_wait_all;
        }
        if (my $bref = delete $lei->{ovv_buf}) {
-               my $out = $lei->{1} or return;
                my $lk = $self->lock_for_scope;
-               print $out $$bref;
+               $lei->out($$bref);
        }
 }
 
@@ -201,16 +194,19 @@ sub _json_pretty {
 
 sub ovv_each_smsg_cb { # runs in wq worker usually
        my ($self, $lei, $ibxish) = @_;
-       my $json;
+       my ($json, $dedupe);
        $lei->{1}->autoflush(1);
-       my $dedupe = $lei->{dedupe} // die 'BUG: {dedupe} missing';
        if (my $pkg = $self->{json}) {
                $json = $pkg->new;
                $json->utf8->canonical;
                $json->ascii(1) if $lei->{opt}->{ascii};
-               $lei->{ovv_buf} = \(my $buf = '');
        }
-       my $l2m = $lei->{l2m} or $dedupe->prepare_dedupe;
+       my $l2m = $lei->{l2m};
+       if (!$l2m) {
+               $dedupe = $lei->{dedupe} // die 'BUG: {dedupe} missing';
+               $dedupe->prepare_dedupe;
+       }
+       $lei->{ovv_buf} = \(my $buf = '') if !$l2m;
        if ($l2m && !$ibxish) { # remote https?:// mboxrd
                delete $l2m->{-wq_s1};
                my $g2m = $l2m->can('git_to_mail');
@@ -221,14 +217,13 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                };
        } elsif ($l2m && $l2m->{-wq_s1}) {
                my ($lei_ipc, @io) = $lei->atfork_parent_wq($l2m);
-               # n.b. $io[0] = qry_status_wr, $io[1] = mbox|stdout,
-               # $io[4] becomes a notification pipe that triggers EOF
+               # $io[-1] becomes a notification pipe that triggers EOF
                # in this wq worker when all outstanding ->write_mail
                # calls are complete
-               die "BUG: \$io[4] $io[4] unexpected" if $io[4];
-               pipe($l2m->{each_smsg_done}, $io[4]) or die "pipe: $!";
-               fcntl($io[4], 1031, 4096) if $^O eq 'linux';
+               pipe($l2m->{each_smsg_done}, $io[$#io + 1]) or die "pipe: $!";
+               fcntl($io[-1], 1031, 4096) if $^O eq 'linux'; # F_SETPIPE_SZ
                delete @$lei_ipc{qw(l2m opt mset_opt cmd)};
+               $lei_ipc->{each_smsg_not_done} = $#io;
                my $git = $ibxish->git; # (LeiXSearch|Inbox|ExtSearch)->git
                $self->{git} = $git;
                my $git_dir = $git->{git_dir};
@@ -243,7 +238,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                my $git = $ibxish->git; # (LeiXSearch|Inbox|ExtSearch)->git
                $self->{git} = $git; # for ovv_atexit_child
                my $g2m = $l2m->can('git_to_mail');
-               $dedupe->prepare_dedupe;
                sub {
                        my ($smsg, $mitem) = @_;
                        $smsg->{pct} = get_pct($mitem) if $mitem;
@@ -251,7 +245,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                };
        } elsif ($self->{fmt} =~ /\A(concat)?json\z/ && $lei->{opt}->{pretty}) {
                my $EOR = ($1//'') eq 'concat' ? "\n}" : "\n},";
-               $lei->{ovv_buf} = \(my $buf = '');
                sub { # DIY prettiness :P
                        my ($smsg, $mitem) = @_;
                        return if $dedupe->is_smsg_dup($smsg);
@@ -267,28 +260,21 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                                }
                        } sort keys %$smsg);
                        $buf .= $EOR;
-                       if (length($buf) > 65536) {
-                               my $lk = $self->lock_for_scope;
-                               print { $lei->{1} } $buf;
-                               $buf = '';
-                       }
+                       return if length($buf) < 65536;
+                       my $lk = $self->lock_for_scope;
+                       $lei->out($buf);
+                       $buf = '';
                }
        } elsif ($json) {
                my $ORS = $self->{fmt} eq 'json' ? ",\n" : "\n"; # JSONL
-               $lei->{ovv_buf} = \(my $buf = '');
                sub {
                        my ($smsg, $mitem) = @_;
                        return if $dedupe->is_smsg_dup($smsg);
                        $buf .= $json->encode(_unbless_smsg(@_)) . $ORS;
-                       if (length($buf) > 65536) {
-                               my $lk = $self->lock_for_scope;
-                               print { $lei->{1} } $buf;
-                               $buf = '';
-                       }
-               }
-       } elsif ($self->{fmt} eq 'oid') {
-               sub {
-                       my ($smsg, $mitem) = @_;
+                       return if length($buf) < 65536;
+                       my $lk = $self->lock_for_scope;
+                       $lei->out($buf);
+                       $buf = '';
                }
        } # else { ...
 }