lei_xsearch: simplify lei/store import check

[public-inbox.git] / lib / PublicInbox / LeiXSearch.pm

diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm
index 119070a289de8bf9b25b8532ece321043286ac40..41e798562d424b097ec611ef5f283f2251d9563b 100644 (file)
--- a/lib/PublicInbox/LeiXSearch.pm
+++ b/lib/PublicInbox/LeiXSearch.pm
@@ -283,20 +283,22 @@ sub each_remote_eml { # callback for MboxReader->mboxrd
        my $smsg = bless {}, 'PublicInbox::Smsg';
        if ($self->{import_sto} && !$xoids) {
                my ($res, $kw) = $self->{import_sto}->wq_do('add_eml', $eml);
-               $smsg = $res if ref($res) eq ref($smsg); # totally new message
+               if (ref($res) eq ref($smsg)) { # totally new message
+                       $smsg = $res;
+                       $self->{-sto_imported} = 1;
+               }
                $smsg->{kw} = $kw; # short-circuit xsmsg_vmd
        }
        $smsg->{blob} //= $xoids ? (keys(%$xoids))[0]
                                : $lei->git_oid($eml)->hexdigest;
        _smsg_fill($smsg, $eml);
        wait_startq($lei);
+       my $nr = ++$lei->{-nr_remote_eml}; # needed for lss->cfg_set
        if ($lei->{-progress}) {
-               ++$lei->{-nr_remote_eml};
                my $now = now();
                my $next = $lei->{-next_progress} //= ($now + 1);
                if ($now > $next) {
                        $lei->{-next_progress} = $now + 1;
-                       my $nr = $lei->{-nr_remote_eml};
                        mset_progress($lei, $lei->{-current_url}, $nr, '?');
                }
        }
@@ -340,7 +342,7 @@ sub query_remote_mboxrd {
        local $SIG{TERM} = sub { exit(0) }; # for DESTROY (File::Temp, $reap)
        my $lei = $self->{lei};
        my $opt = $lei->{opt};
-       my $qstr = $lei->{mset_opt}->{qstr};
+       chomp(my $qstr = $lei->{mset_opt}->{qstr});
        $qstr =~ s/[ \n\t]+/ /sg; # make URLs less ugly
        my @qform = (x => 'm');
        push(@qform, t => 1) if $opt->{threads};
@@ -374,13 +376,14 @@ sub query_remote_mboxrd {
                $fh = IO::Uncompress::Gunzip->new($fh, MultiStream => 1);
                PublicInbox::MboxReader->mboxrd($fh, \&each_remote_eml, $self,
                                                $lei, $each_smsg);
-               my $nr = $lei->{-nr_remote_eml};
-               my $wait = $lei->{sto}->wq_do('done') if $nr && $lei->{sto};
+               if (delete($self->{-sto_imported})) {
+                       my $wait = $self->{import_sto}->wq_do('done');
+               }
                $reap_curl->join;
                if ($? == 0) {
                        # don't update if no results, maybe MTA is down
-                       $key && $nr and
-                               $lei->{lss}->cfg_set($key, $start);
+                       my $nr = $lei->{-nr_remote_eml};
+                       $lei->{lss}->cfg_set($key, $start) if $key && $nr;
                        mset_progress($lei, $lei->{-current_url}, $nr, $nr);
                        next;
                }
@@ -406,7 +409,10 @@ sub git { $_[0]->{git} // die 'BUG: git uninitialized' }
 sub xsearch_done_wait { # dwaitpid callback
        my ($arg, $pid) = @_;
        my ($wq, $lei) = @$arg;
-       $lei->child_error($?, 'non-fatal error from '.ref($wq)) if $?;
+       return if !$?;
+       my $s = $? & 127;
+       return $lei->child_error($?) if $s == 13 || $s == 15;
+       $lei->child_error($?, 'non-fatal error from '.ref($wq)." \$?=$?");
 }
 
 sub query_done { # EOF callback for main daemon
@@ -548,7 +554,7 @@ sub do_query {
                'child_error' => [ $lei ],
                'incr_start_query' => [ $self, $lei ],
        };
-       $lei->{auth}->op_merge($ops, $l2m) if $l2m && $lei->{auth};
+       $lei->{auth}->op_merge($ops, $l2m, $lei) if $l2m && $lei->{auth};
        my $end = $lei->pkt_op_pair;
        $lei->{1}->autoflush(1);
        $lei->start_pager if delete $lei->{need_pager};