treewide: "require" + "use" cleanup and docs

[public-inbox.git] / lib / PublicInbox / MboxGz.pm

diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm
index 2a55447f84e873b7fedb0db4b969128856c7eb5a..08e3c8464c4fb800fc075cd145d92ec16820a39e 100644 (file)
--- a/lib/PublicInbox/MboxGz.pm
+++ b/lib/PublicInbox/MboxGz.pm
@@ -6,7 +6,6 @@ use warnings;
 use Email::Simple;
 use PublicInbox::Hval qw/to_filename/;
 use PublicInbox::Mbox;
-use IO::Compress::Gzip;
 use Compress::Raw::Zlib qw(Z_FINISH Z_OK);
 my %OPT = (-WindowBits => 15 + 16, -AppendOutput => 1);
 
@@ -23,7 +22,7 @@ sub response {
        my $body = $class->new($ctx, $cb);
        # http://www.iana.org/assignments/media-types/application/gzip
        my @h = qw(Content-Type application/gzip);
-       if ($fn) {
+       if (defined $fn && $fn ne '') {
                $fn = to_filename($fn);
                push @h, 'Content-Disposition', "inline; filename=$fn.mbox.gz";
        }
@@ -42,7 +41,7 @@ sub getline {
        my $ctx = $self->{ctx} or return;
        my $gz = $self->{gz};
        my $buf = delete($self->{buf});
-       while (my $smsg = $self->{cb}->()) {
+       while (my $smsg = $self->{cb}->($ctx)) {
                my $mref = $ctx->{-inbox}->msg_by_smsg($smsg) or next;
                my $h = Email::Simple->new($mref)->header_obj;
 
@@ -63,7 +62,7 @@ sub getline {
        # signal that we're done and can return undef next call:
        delete $self->{ctx};
        my $err = $gz->flush($buf, Z_FINISH);
-       $err == Z_OK ? $buf : gzip_fail($ctx, $err);
+       ($err == Z_OK) ? $buf : gzip_fail($ctx, $err);
 }
 
 sub close {} # noop