msgmap: use v5.10.1

[public-inbox.git] / lib / PublicInbox / Msgmap.pm

diff --git a/lib/PublicInbox/Msgmap.pm b/lib/PublicInbox/Msgmap.pm
index 7290959d22c07e0ef66836435304ca03c81f67eb..d696ce837395bcbc0800a09e41290f8f1e5fee02 100644 (file)
--- a/lib/PublicInbox/Msgmap.pm
+++ b/lib/PublicInbox/Msgmap.pm
@@ -6,9 +6,10 @@
 # numbers for NNTP and allows prefix lookups for partial Message-IDs
 # in case URLs get truncated from copy-n-paste errors by users.
 #
-# This is maintained by ::SearchIdx
+# This is maintained by ::SearchIdx (v1) and ::V2Writable (v2)
 package PublicInbox::Msgmap;
 use strict;
+use v5.10.1;
 use DBI;
 use DBD::SQLite;
 use PublicInbox::Over;
@@ -31,9 +32,6 @@ sub new_file {
        my $self = bless { filename => $f }, $class;
        my $dbh = $self->{dbh} = PublicInbox::Over::dbh_new($self, $rw);
        if ($rw) {
-               # TRUNCATE reduces I/O compared to the default (DELETE)
-               $dbh->do('PRAGMA journal_mode = TRUNCATE');
-
                $dbh->begin_work;
                create_tables($dbh);
                $self->created_at(time) unless $self->created_at;
@@ -175,18 +173,20 @@ sub num_delete {
 
 sub create_tables {
        my ($dbh) = @_;
-       my $e;
-
-       $e = eval { $dbh->selectrow_array('EXPLAIN SELECT * FROM msgmap;') };
-       defined $e or $dbh->do('CREATE TABLE msgmap (' .
-                       'num INTEGER PRIMARY KEY AUTOINCREMENT, '.
-                       'mid VARCHAR(1000) NOT NULL, ' .
-                       'UNIQUE (mid) )');
-
-       $e = eval { $dbh->selectrow_array('EXPLAIN SELECT * FROM meta') };
-       defined $e or $dbh->do('CREATE TABLE meta (' .
-                       'key VARCHAR(32) PRIMARY KEY, '.
-                       'val VARCHAR(255) NOT NULL)');
+
+       $dbh->do(<<'');
+CREATE TABLE IF NOT EXISTS msgmap (
+       num INTEGER PRIMARY KEY AUTOINCREMENT,
+       mid VARCHAR(1000) NOT NULL,
+       UNIQUE (mid)
+)
+
+       $dbh->do(<<'');
+CREATE TABLE IF NOT EXISTS meta (
+       key VARCHAR(32) PRIMARY KEY,
+       val VARCHAR(255) NOT NULL
+)
+
 }
 
 # used by NNTP.pm