searchidx: disable CoW for SQLite and Xapian under btrfs

[public-inbox.git] / lib / PublicInbox / Over.pm

diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 74c8fb862703b5a44bbef229670762fb3c856c1a..0146414cf4f2ebcf9575714b090e98992b201797 100644 (file)
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -15,9 +15,18 @@ use constant DEFAULT_LIMIT => 1000;
 
 sub dbh_new {
        my ($self, $rw) = @_;
-       my $f = $self->{filename};
-       if ($rw && !-f $f) { # SQLite defaults mode to 0644, we want 0666
-               open my $fh, '+>>', $f or die "failed to open $f: $!";
+       my $f = delete $self->{filename};
+       if (!-f $f) { # SQLite defaults mode to 0644, we want 0666
+               if ($rw) {
+                       require PublicInbox::Spawn;
+                       open my $fh, '+>>', $f or die "failed to open $f: $!";
+                       PublicInbox::Spawn::set_nodatacow(fileno($fh));
+                       my $j = "$f-journal";
+                       open $fh, '+>>', $j or die "failed to open $j: $!";
+                       PublicInbox::Spawn::set_nodatacow(fileno($fh));
+               } else {
+                       $self->{filename} = $f; # die on stat() below:
+               }
        }
        my (@st, $st, $dbh);
        my $tries = 0;
@@ -36,7 +45,7 @@ sub dbh_new {
                $st = pack('dd', $st[0], $st[1]);
        } while ($st ne $self->{st} && $tries++ < 3);
        warn "W: $f: .st_dev, .st_ino unstable\n" if $st ne $self->{st};
-       $dbh->{sqlite_unicode} = 1;
+       $dbh->do('PRAGMA synchronous = OFF') if ($rw // 0) > 1;
        $dbh;
 }
 
@@ -45,9 +54,14 @@ sub new {
        bless { filename => $f }, $class;
 }
 
-sub disconnect { $_[0]->{dbh} = undef }
+sub disconnect {
+       my ($self) = @_;
+       if (my $dbh = delete $self->{dbh}) {
+               $self->{filename} = $dbh->sqlite_db_filename;
+       }
+}
 
-sub connect { $_[0]->{dbh} ||= $_[0]->dbh_new }
+sub connect { $_[0]->{dbh} //= $_[0]->dbh_new }
 
 sub load_from_row ($;$) {
        my ($smsg, $cull) = @_;
@@ -248,36 +262,29 @@ SELECT MAX(num) FROM over WHERE num > 0
        $sth->fetchrow_array // 0;
 }
 
-sub imap_status {
+sub imap_exists {
        my ($self, $uid_base, $uid_end) = @_;
-       my $dbh = $self->connect;
-       my $sth = $dbh->prepare_cached(<<'', undef, 1);
+       my $sth = $self->connect->prepare_cached(<<'', undef, 1);
 SELECT COUNT(num) FROM over WHERE num > ? AND num <= ?
 
        $sth->execute($uid_base, $uid_end);
-       my $exists = $sth->fetchrow_array;
-
-       $sth = $dbh->prepare_cached(<<'', undef, 1);
-SELECT MAX(num) + 1 FROM over WHERE num <= ?
-
-       $sth->execute($uid_end);
-       my $uidnext = $sth->fetchrow_array;
-
-       $sth = $dbh->prepare_cached(<<'', undef, 1);
-SELECT MAX(num) FROM over WHERE num > 0
-
-       ($exists, $uidnext, $sth->fetchrow_array // 0);
+       $sth->fetchrow_array;
 }
 
 sub check_inodes {
        my ($self) = @_;
-       if (my @st = stat($self->{filename})) { # did st_dev, st_ino change?
+       my $dbh = $self->{dbh} or return;
+       my $f = $dbh->sqlite_db_filename;
+       if (my @st = stat($f)) { # did st_dev, st_ino change?
                my $st = pack('dd', $st[0], $st[1]);
 
                # don't actually reopen, just let {dbh} be recreated later
-               delete($self->{dbh}) if ($st ne ($self->{st} // $st));
+               if ($st ne ($self->{st} // $st)) {
+                       delete($self->{dbh});
+                       $self->{filename} = $f;
+               }
        } else {
-               warn "W: stat $self->{filename}: $!\n";
+               warn "W: stat $f: $!\n";
        }
 }