# XXX FIXME: duplicated stuff from NNTP.pm and IMAP.pm
-sub err ($$;@) {
- my ($self, $fmt, @args) = @_;
- printf { $self->{pop3d}->{err} } $fmt."\n", @args;
-}
-
sub out ($$;@) {
my ($self, $fmt, @args) = @_;
printf { $self->{pop3d}->{out} } $fmt."\n", @args;
ORDER BY num ASC
$sth->execute($beg, $end);
- do {
- $m = $sth->fetchall_arrayref({}, 1000);
+ my $tot = 0;
+ while (defined($m = $sth->fetchall_arrayref({}, 1000))) {
for my $x (@$m) {
PublicInbox::Over::load_from_row($x);
push(@cache, $x->{num}, $x->{bytes} + 0, $x->{blob});
undef $x; # saves ~1.5M memory w/ 50k messages
+ $tot += $cache[-2];
}
- } while (scalar(@$m) && ($beg = $cache[-3] + 1));
- \@cache;
+ }
+ $self->{total_bytes} = $tot;
+ $self->{cache} = \@cache;
}
sub cmd_stat {
my ($self) = @_;
my $err; $err = need_txn($self) and return $err;
- my $cache = $self->{cache} //= _stat_cache($self);
- my $tot = 0;
- for (my $i = 1; $i < scalar(@$cache); $i += 3) { $tot += $cache->[$i] }
+ my $cache = $self->{cache} // _stat_cache($self);
my $nr = @$cache / 3 - ($self->{nr_dele} // 0);
- "+OK $nr $tot\r\n";
+ "+OK $nr $self->{total_bytes}\r\n";
}
# for LIST and UIDL
sub _list {
my ($desc, $idx, $self, $msn) = @_;
my $err; $err = need_txn($self) and return $err;
- my $cache = $self->{cache} //= _stat_cache($self);
+ my $cache = $self->{cache} // _stat_cache($self);
if (defined $msn) {
my $base_off = ($msn - 1) * 3;
my $val = $cache->[$base_off + $idx] //
my $old = $self->{txn_max_uid} //= $uid;
$self->{txn_max_uid} = $uid if $uid > $old;
+ $self->{total_bytes} -= $cache->[$base_off + 1];
$cache->[$base_off] = undef; # clobber UID
- $cache->[$base_off + 1] = 0; # zero bytes (simplifies cmd_stat)
+ $cache->[$base_off + 1] = undef; # clobber bytes
$cache->[$base_off + 2] = undef; # clobber oidhex
++$self->{nr_dele};
}
my @tmp = split(/^/m, $bdy);
$hdr .= join('', splice(@tmp, 0, $top_nr));
} elsif (exists $self->{expire}) {
- $self->{expire} .= pack('S', $off + 1);
+ $self->{expire} .= pack('S', $off);
}
$$bref =~ s/^\./../gms;
$$bref .= substr($$bref, -2, 2) eq "\r\n" ? ".\r\n" : "\r\n.\r\n";
return \"-ERR lines must be a non-negative number\r\n" if
(defined($top_nr) && $top_nr !~ /\A[0-9]+\z/);
my $err; $err = need_txn($self) and return $err;
- my $cache = $self->{cache} //= _stat_cache($self);
+ my $cache = $self->{cache} // _stat_cache($self);
my $off = $msn - 1;
my $hex = $cache->[$off * 3 + 2] // return \"-ERR no such message\r\n";
${ibx_async_cat($self->{ibx}, $hex, \&retr_cb,
sub cmd_dele {
my ($self, $msn) = @_;
my $err; $err = need_txn($self) and return $err;
- $self->{cache} //= _stat_cache($self);
+ $self->{cache} // _stat_cache($self);
$msn =~ /\A[1-9][0-9]*\z/ or return \"-ERR no such message\r\n";
mark_dele($self, $msn - 1) ? \"+OK\r\n" : \"-ERR no such message\r\n";
}
$self->SUPER::close;
}
+# must be called inside a state_dbh transaction with flock held
+sub __cleanup_state {
+ my ($self, $txn_id) = @_;
+ my $user_id = $self->{user_id} // die 'BUG: no {user_id}';
+ $self->{pop3d}->{-state_dbh}->prepare_cached(<<'')->execute($txn_id);
+DELETE FROM deletes WHERE txn_id = ? AND uid_dele = -1
+
+ my $sth = $self->{pop3d}->{-state_dbh}->prepare_cached(<<'', undef, 1);
+SELECT COUNT(*) FROM deletes WHERE user_id = ?
+
+ $sth->execute($user_id);
+ my $nr = $sth->fetchrow_array;
+ if ($nr == 0) {
+ $sth = $self->{pop3d}->{-state_dbh}->prepare_cached(<<'');
+DELETE FROM users WHERE user_id = ?
+
+ $sth->execute($user_id);
+ }
+ $nr;
+}
+
sub cmd_quit {
my ($self) = @_;
if (defined(my $txn_id = $self->{txn_id})) {
if (my $exp = delete $self->{expire}) {
mark_dele($self, $_) for unpack('S*', $exp);
}
+ my $keep = 1;
my $dbh = $self->{pop3d}->{-state_dbh};
my $lk = $self->{pop3d}->lock_for_scope;
- my $sth;
$dbh->begin_work;
- if (defined $self->{txn_max_uid}) {
- $sth = $dbh->prepare_cached(<<'');
+ if (defined(my $max = $self->{txn_max_uid})) {
+ $dbh->prepare_cached(<<'')->execute($max, $txn_id, $max)
UPDATE deletes SET uid_dele = ? WHERE txn_id = ? AND uid_dele < ?
- $sth->execute($self->{txn_max_uid}, $txn_id,
- $self->{txn_max_uid});
+ } else {
+ $keep = $self->__cleanup_state($txn_id);
}
- $sth = $dbh->prepare_cached(<<'');
+ $dbh->prepare_cached(<<'')->execute(time, $user_id) if $keep;
UPDATE users SET last_seen = ? WHERE user_id = ?
- $sth->execute(time, $user_id);
$dbh->commit;
+ # we MUST do txn_id F_UNLCK here inside ->lock_for_scope:
+ $self->{did_quit} = 1;
+ $self->{pop3d}->unlock_mailbox($self);
}
$self->write(\"+OK public-inbox POP3 server signing off\r\n");
$self->close;
\"-ERR command not recognized\r\n";
my $err = $@;
if ($err && $self->{sock}) {
- chomp($l);
- err($self, 'error from: %s (%s)', $l, $err);
+ $l =~ s/\r?\n//s;
+ warn("error from: $l ($err)\n");
$res = \"-ERR program fault - command not performed\r\n";
}
defined($res) ? $self->write($res) : 0;
# callback used by PublicInbox::DS for any (e)poll (in/out/hup/err)
sub event_step {
my ($self) = @_;
+ local $SIG{__WARN__} = $self->{pop3d}->{warn_cb};
return unless $self->flush_write && $self->{sock} && !$self->{long_cb};
# only read more requests if we've drained the write buffer,