qspawn: use per-call quiet flag for solver

[public-inbox.git] / lib / PublicInbox / Qspawn.pm

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 1a2b70e7b442e8a2373ebd2ae207d6555a6bab9e..65bb178aba44a216f73c221338aebd5f7a9dba92 100644 (file)
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -56,9 +56,7 @@ sub _do_spawn {
 
        ($self->{rpipe}, $self->{pid}) = popen_rd($cmd, $cmd_env, \%opts);
 
-       # drop any IO handles opt was holding open via $opt->{hold}
-       # No need to hold onto the descriptor once the child process has it.
-       $self->{args} = $cmd; # keep this around for logging
+       $self->{args} = $opts{quiet} ? undef : $cmd;
 
        if (defined $self->{pid}) {
                $limiter->{running}++;
@@ -108,7 +106,7 @@ sub waitpid_err ($$) {
 
        if ($err) {
                $self->{err} = $err;
-               if ($env && !$env->{'qspawn.quiet'}) {
+               if ($env && $self->{args}) {
                        log_err($env, join(' ', @{$self->{args}}) . ": $err");
                }
        }