treewide: avoid `goto &NAME' for tail recursion

[public-inbox.git] / lib / PublicInbox / View.pm

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 9c3ef104f1a83ab28edfce75cf2ce2308ad3af76..1d5119cd1bdf9a451e91ba5fd8a9bc13aec9a957 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -386,7 +386,7 @@ sub next_in_queue ($$) {
 
 sub stream_thread_i { # PublicInbox::WwwStream::getline callback
        my ($ctx, $eml) = @_;
-       goto &thread_eml_entry if $eml; # tail recursion
+       return thread_eml_entry($ctx, $eml) if $eml;
        return unless exists($ctx->{skel});
        my $ghost_ok = $ctx->{nr}++;
        while (1) {
@@ -1175,9 +1175,9 @@ sub pagination_footer ($$) {
        my ($ctx, $latest) = @_;
        my $next = $ctx->{next_page} || '';
        my $prev = $ctx->{prev_page} || '';
-       if ($prev) {
-               $next = $next ? "$next " : '     ';
-               $prev .= qq! <a\nhref='$latest'>latest</a>!;
+       if ($prev) {  # aligned padding for: 'next (older) | '
+               $next = $next ? "$next | " : '             | ';
+               $prev .= qq[ | <a\nhref="$latest">latest</a>];
        }
        "<hr><pre>page: $next$prev</pre>";
 }
@@ -1215,11 +1215,13 @@ sub paginate_recent ($$) {
        }
        if (defined($oldest) && $more) {
                my $s = ts2str($oldest);
-               $ctx->{next_page} = qq!<a\nhref="?t=$s"\nrel=next>next</a>!;
+               $ctx->{next_page} = qq[<a\nhref="?t=$s"\nrel=next>] .
+                                       'next (older)</a>';
        }
        if (defined($newest) && (defined($before) || defined($after))) {
                my $s = ts2str($newest);
-               $ctx->{prev_page} = qq!<a\nhref="?t=$s-"\nrel=prev>prev</a>!;
+               $ctx->{prev_page} = qq[<a\nhref="?t=$s-"\nrel=prev>] .
+                                       'prev (newer)</a>';
        }
        $msgs;
 }